From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E25B142F6C; Fri, 28 Jul 2023 17:37:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64B7840685; Fri, 28 Jul 2023 17:37:35 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 4D5064021E for ; Fri, 28 Jul 2023 17:37:34 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DFA635C018E; Fri, 28 Jul 2023 11:37:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 28 Jul 2023 11:37:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690558653; x=1690645053; bh=j0e3o4W8qY202xH1gQzFiYHqymRDj8xW3o8 B7l8uubE=; b=ulkH4YHhyCqXgaQ6EDqFeYXz2c8ouCzPWlaxtTgQ45t/m0hl7zQ IxRUSG4xx44R3qEshFnh5yxpFoa+g24BM9M7J0H4bhfujnDgbSJ9A0wvfP73L1pz PjPeqm5dDGpU73pOlWPdiinfqT/skRSW/XK6Xhk21N4siMTmz21fahoSknho+PyU 90p5ULYYZ/e6Rp4q/xHfWWN5qOsCLnS4Tckjcka8kARhPI6rr/mB+BzldzoM2vG4 U4oxIhP5Z9Hp28wIPmWXmg2ZoC1ZnqhHAnMqwup6Hvhq2TG1oo7EGAIWqWo5QSLb vW29D7xhWoaq6U+gAX8n6+fnFWvG/T+QGsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690558653; x=1690645053; bh=j0e3o4W8qY202xH1gQzFiYHqymRDj8xW3o8 B7l8uubE=; b=X6gfpCBGxmr2C/TG7kup4/J4owUtj0ZVsEeFu7kgFsaCN+4arr2 Smy0UaK+tZswWMpkXP6vAiX8vRf3TFBS6E2MklitFyidqXJFeYza8EOB0Cvc54z2 IFFe9P24YY8sfsJDqNy2PRRX1i2aET21Mb8SspxrpfYxBznqTR2k0ngqz3OCwzY6 qLBj9mFL+iyY6oaj+ZM34oQfn/bnbbzs77yhH2I9NPgB7h2X0TBqCxz0ysNEroEO H3v5a7Qjr7KP6V8QZD2LVVzCKZJaknd7R0YdX5CGChrdOnQnOkzUXTbLqMlYx04w yaqVvzI8HP+V5+iuOS8RmqRMMTUmr4Zn03Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jul 2023 11:37:32 -0400 (EDT) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, nd@arm.com, Honnappa.Nagarahalli@arm.com, Feifei Wang , Ruifeng Wang , Feifei Wang , ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, andrew.rybchenko@oktetlabs.ru Subject: Re: [PATCH] doc: announce ethdev operation struct changes Date: Fri, 28 Jul 2023 17:37:30 +0200 Message-ID: <3047655.CbtlEUcBR6@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87AA4@smartserver.smartshare.dk> References: <20230704081006.1202932-1-feifei.wang2@arm.com> <1783013.TLkxdtWsSY@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87AA4@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/07/2023 17:33, Morten Br=F8rup: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Friday, 28 July 2023 17.20 > >=20 > > 28/07/2023 17:08, Morten Br=F8rup: > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Sent: Friday, 28 July 2023 16.57 > > > > > > > > 04/07/2023 10:10, Feifei Wang: > > > > > To support mbufs recycle mode, announce the coming ABI changes > > > > > from DPDK 23.11. > > > > > > > > > > Signed-off-by: Feifei Wang > > > > > Reviewed-by: Ruifeng Wang > > > > > --- > > > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > > > 1 file changed, 4 insertions(+) > > > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > > b/doc/guides/rel_notes/deprecation.rst > > > > > index 66431789b0..c7e1ffafb2 100644 > > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > > @@ -118,6 +118,10 @@ Deprecation Notices > > > > > The legacy actions should be removed > > > > > once ``MODIFY_FIELD`` alternative is implemented in drivers. > > > > > > > > > > +* ethdev: The Ethernet device data structure ``struct rte_eth_de= v`` and > > > > > + the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will= be > > updated > > > > > + with new fields to support mbufs recycle mode from DPDK 23.11. > > > > > > Existing fields will also be moved around [1]: > > > > > > @@ -83,15 +90,17 @@ struct rte_eth_fp_ops { > > > * Rx fast-path functions and related data. > > > * 64-bit systems: occupies first 64B line > > > */ > > > + /** Rx queues data. */ > > > + struct rte_ethdev_qdata rxq; > > > /** PMD receive function. */ > > > eth_rx_burst_t rx_pkt_burst; > > > /** Get the number of used Rx descriptors. */ > > > eth_rx_queue_count_t rx_queue_count; > > > /** Check the status of a Rx descriptor. */ > > > eth_rx_descriptor_status_t rx_descriptor_status; > > > - /** Rx queues data. */ > > > - struct rte_ethdev_qdata rxq; > > > - uintptr_t reserved1[3]; > > > + /** Refill Rx descriptors with the recycling mbufs. */ > > > + eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill; > > > + uintptr_t reserved1[2]; > > > /**@}*/ > > > > > > /**@{*/ > > > @@ -99,15 +108,17 @@ struct rte_eth_fp_ops { > > > * Tx fast-path functions and related data. > > > * 64-bit systems: occupies second 64B line > > > */ > > > + /** Tx queues data. */ > > > + struct rte_ethdev_qdata txq; > > > /** PMD transmit function. */ > > > eth_tx_burst_t tx_pkt_burst; > > > /** PMD transmit prepare function. */ > > > eth_tx_prep_t tx_pkt_prepare; > > > /** Check the status of a Tx descriptor. */ > > > eth_tx_descriptor_status_t tx_descriptor_status; > > > - /** Tx queues data. */ > > > - struct rte_ethdev_qdata txq; > > > - uintptr_t reserved2[3]; > > > + /** Copy used mbufs from Tx mbuf ring into Rx. */ > > > + eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse; > > > + uintptr_t reserved2[2]; > > > /**@}*/ > >=20 > > Removing existing fields should be announced explicitly. >=20 > Agreed. And the patch misses this. The "rxq" and "txq" fields are not bei= ng removed, they are being moved up in the structures. Your comment about e= xplicit mentioning still applies! >=20 > If there's no time to wait for a new patch version from Feifei, perhaps y= ou improve the description while merging. If it's only moving fields, we can skip. The real change is the size of the reserved fields, so it looks acceptable without notice.