From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 52E3C1B0F9 for ; Wed, 3 Apr 2019 01:48:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF02821BCA; Tue, 2 Apr 2019 19:48:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 19:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CkWQpNLJHhm7o2XiIRg5MrdQbXE/D2Ax55t/Fnta7bc=; b=hVr5fs4TuoI0 p+xB0xmiXlAhCbnUBwHxaEcfBkHQ6mWA2XGE6t6OImQSUgF25KBZdxk3EYCisF6/ i0RPQV8+E/pIcMLWY0HKMq5I43hX8TVGnqS9m1L1NSZVqZu43Vu4mLCp7eBnXa46 EQQ+5mW/rNwzeH+Kn/kNGdUe1oRmCnE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CkWQpNLJHhm7o2XiIRg5MrdQbXE/D2Ax55t/Fnta7 bc=; b=mZzFVD7j84XD4KGJdeT998Zvwfw8z3ARDuMC+RUyHo1Ij8Ig3EcTYnNYd KxoEocXMHdhBFsSlFec3/MoguIk/8eiYryYKuiZsjLSNB4NBZte4iuQ0cxPwcIHO JV9TJjzmbonA0GiunyJ3YPSB6vaE4t4JGa8FIh9K+HNmNr+rMHvfh8yFRtOZpeXb k1yquos4f/intIgNwCE/ZGS5Jk0yhIL+65GCQTt/uJXQxrrxM3Bw2soVwDrtZsuk x9roeGetgJC7bObwP2DwcQA+pAByqQ9pmHBBdd5sIIyvUBFe5aZdkq3KfEcrk9Eg WcZNTVa62TZCiCr5CnU883BAbssrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddvheculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E1D2FE4805; Tue, 2 Apr 2019 19:48:42 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: gaetan.rivet@6wind.com, Andrew Rybchenko , dev@dpdk.org Date: Wed, 03 Apr 2019 01:48:41 +0200 Message-ID: <30477655.WWphSIAI62@xps> In-Reply-To: <09b6795e-9247-6599-1c5e-1d398739b1e6@intel.com> References: <20181130002716.27325-1-thomas@monjalon.net> <20190401022700.1570-3-thomas@monjalon.net> <09b6795e-9247-6599-1c5e-1d398739b1e6@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: add siblings iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 23:48:46 -0000 03/04/2019 01:42, Ferruh Yigit: > On 4/1/2019 3:26 AM, Thomas Monjalon wrote: > > +__rte_experimental > > +uint16_t rte_eth_find_next_of(uint16_t port_id_start, > > + const struct rte_device *parent); > > Minor nit, but other instances using the tag as: > > uint16_t __rte_experimental > rte_eth_find_next_of(uint16_t port_id_start, > const struct rte_device *parent); > > What do you think updating it for consistency? Same for two APIs. I think I did it this way to minimize the patch removing it later. I'm OK to change it for consistency. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F0BDAA0679 for ; Wed, 3 Apr 2019 01:48:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0FC41B123; Wed, 3 Apr 2019 01:48:47 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 52E3C1B0F9 for ; Wed, 3 Apr 2019 01:48:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF02821BCA; Tue, 2 Apr 2019 19:48:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 19:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CkWQpNLJHhm7o2XiIRg5MrdQbXE/D2Ax55t/Fnta7bc=; b=hVr5fs4TuoI0 p+xB0xmiXlAhCbnUBwHxaEcfBkHQ6mWA2XGE6t6OImQSUgF25KBZdxk3EYCisF6/ i0RPQV8+E/pIcMLWY0HKMq5I43hX8TVGnqS9m1L1NSZVqZu43Vu4mLCp7eBnXa46 EQQ+5mW/rNwzeH+Kn/kNGdUe1oRmCnE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CkWQpNLJHhm7o2XiIRg5MrdQbXE/D2Ax55t/Fnta7 bc=; b=mZzFVD7j84XD4KGJdeT998Zvwfw8z3ARDuMC+RUyHo1Ij8Ig3EcTYnNYd KxoEocXMHdhBFsSlFec3/MoguIk/8eiYryYKuiZsjLSNB4NBZte4iuQ0cxPwcIHO JV9TJjzmbonA0GiunyJ3YPSB6vaE4t4JGa8FIh9K+HNmNr+rMHvfh8yFRtOZpeXb k1yquos4f/intIgNwCE/ZGS5Jk0yhIL+65GCQTt/uJXQxrrxM3Bw2soVwDrtZsuk x9roeGetgJC7bObwP2DwcQA+pAByqQ9pmHBBdd5sIIyvUBFe5aZdkq3KfEcrk9Eg WcZNTVa62TZCiCr5CnU883BAbssrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddvheculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E1D2FE4805; Tue, 2 Apr 2019 19:48:42 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: gaetan.rivet@6wind.com, Andrew Rybchenko , dev@dpdk.org Date: Wed, 03 Apr 2019 01:48:41 +0200 Message-ID: <30477655.WWphSIAI62@xps> In-Reply-To: <09b6795e-9247-6599-1c5e-1d398739b1e6@intel.com> References: <20181130002716.27325-1-thomas@monjalon.net> <20190401022700.1570-3-thomas@monjalon.net> <09b6795e-9247-6599-1c5e-1d398739b1e6@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: add siblings iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402234841.QjXx7xANsp3VlcfL5bqUkfKZHi9Hbx08OEn9AIMqrxc@z> 03/04/2019 01:42, Ferruh Yigit: > On 4/1/2019 3:26 AM, Thomas Monjalon wrote: > > +__rte_experimental > > +uint16_t rte_eth_find_next_of(uint16_t port_id_start, > > + const struct rte_device *parent); > > Minor nit, but other instances using the tag as: > > uint16_t __rte_experimental > rte_eth_find_next_of(uint16_t port_id_start, > const struct rte_device *parent); > > What do you think updating it for consistency? Same for two APIs. I think I did it this way to minimize the patch removing it later. I'm OK to change it for consistency.