From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 283D943C27; Fri, 8 Mar 2024 18:23:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1884B42F77; Fri, 8 Mar 2024 18:23:24 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) by mails.dpdk.org (Postfix) with ESMTP id E9B4742F61; Fri, 8 Mar 2024 18:23:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahUNA8ICDb1+amoQ/2rOgZoLbYZC+Ku2uhda5ldsGNpRCSHDTNARxe8zKt06aicBnJY011iAh61+/Z2CufKrH81orxu6P8l654r4Y2S32SjwhqOWmQ+qc287hwH/VAAwG/OoFU5AoUvUHXNCk2FzN+iamkt3FEt+uNkLW0qErfWiYbI7rrc3GTC2iKRlDWiKaqwtIJPBIWHDKIogpC4NKcAJqXuzzHiLVuVrWrGQkxHpRUTY+s5UW9nqPJU7m3xGylX/RoOiMVg20nlbyMv+QiMkDINRqvqRqTe3Yay8D9oWjLAPWzhj0f5OArdgKpj19kOMU/8lb9IWya5qflTdmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wuur7Ls8xo7cAII3o2A+uR9ud0u/+r4T5bOHBSlL5Y=; b=DTPbbgkYRE4eJX4xawIjhylST/McUAKihX8ok3fRVF5omLeV2rV+VbGkAs0lgVkn5X/HwVSN/1B+DilXzld97Xrje2wF1fYk98dYBoojKyUT9YU+OScpfaD0FBdN/t+H5ugPI4WHWwZc3/pY9+XaTTU9Cnu89mYUU1bds82esbyTI1ykoYxFNyLpvGXb7kdcz1qj5LRyqVfvNJT3mrNfBeEZnKEVE1ztxTCcCxGfuMThXyCVZIHr6NO7JOZKeUG4nBYKBdoqZw6I70McvoHqQhUdXuAoSM+0LnfztZnMP0OhtWvHAJwWbVkR1I+Gn1RiZNknM6HHdJ9k7mIqMo1sTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wuur7Ls8xo7cAII3o2A+uR9ud0u/+r4T5bOHBSlL5Y=; b=YxwXSMNl+0uRjLmzcvgZgW38h7C9Y8PAgGIqwlS8hVZeMaWdEjB0lLmvJSf+BNuME2MyBanqWZPoZFxKI9flSvErj43CRTB8uLRAq70z1lwiiG1iFkBjC9BmXNSjcy0cfe8oaSgkb5YRyQD93YJTRGLaPYnbFFHEnP2stncUpg8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB7829.namprd12.prod.outlook.com (2603:10b6:806:316::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 17:23:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.028; Fri, 8 Mar 2024 17:23:20 +0000 Message-ID: <3047c09e-9403-46ee-a13f-f269ed81f78b@amd.com> Date: Fri, 8 Mar 2024 17:23:19 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/33] net/ena: fix fast mbuf free Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org, stable@dpdk.org References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-6-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240306122445.4350-6-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0217.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB7829:EE_ X-MS-Office365-Filtering-Correlation-Id: 71d462bf-af07-4943-24ff-08dc3f94736c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cm5xYXzDcMnuKL65xTENek7ydvYJwVYrlYAJ7k/QDcygybEZK48Q1XKvivT54s7kqs5T5R1Yx6UrZrx4JFMDJnhvBRS2rLDBMfB4SzVCRXk1fIc1/F/axuGgRCP5xW8ufdQQpL3D0GUESmHQtXoena/m4TnxUGqE8v9DFLQp2GdtXM4dmb1W6MkarT9IF8StxInfl3WgmGAHAQtWzPnAHE1HRSeZ+FVQgA5mzMWA3odBp5lgcjWxy/6oS+77K4bofT9MstJUcrYyWZ/o22MhWJHXpck5vOpDAL/IdaLjWSbN97xKoHK0tMdTv3gqbWvuvzbqc1bpnQ72r8DLcP3LOUSAiJqHZP32/hw8o/5QTY9fC+to+8YfpDJ2FQfq/oV1eK1LXid/e/QYIORwJlni/ArPhsB7WhZXd3hzpbjiUb6oumawzyjZbZ9bwPNgWy2bkT2uKdleF3ZSVe9uB11PdDTsZuhnLZW6OwgErP09RUyvhJdKUqGiOVmEMsoonJ91Vm/M+CQu2j5qFVxWx1Ps90lssJC+4GrihdZdFGKXTJWcUhzQHFYTcKBkqWPBvfbnwepqzuYtJ2w2WQK3ickv3WhBF/1PaWSZX0e592A0mlKIe42O7tYRqiRtS+ktlvcMQPX+M8gU9ffJE5+NvthBPucuwl/l9pKWZzk5+Od+Jxc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjdJZHU2dTJvTWlmK0o0cEI5Szl3NHN2b0I3dGhtZFBMZXpuWVY1dUk3WC9j?= =?utf-8?B?VU9yWjBOZWlYZDVVQ1FwZmxxdVF3OUFva1BTNWcwNXQ4bVJPNThjN21QeDAr?= =?utf-8?B?TTN3MFpNS3Y2eVFORjBnVVl6YTZLMXMvaXdlUGZUc3NBVHpGUjZuMEpUbnVY?= =?utf-8?B?OG1icmhCZ1Qwd3lFZlBuYUJLRm5xd2dWWWpBR1dGVGpncm5tRWNYUnU2VkIx?= =?utf-8?B?Zkl5bE9jRHduRkpCOHJ5MFhjSG9ScjhkNVVqUmwvK1Q1Vm1jYVdhaU5sVVUx?= =?utf-8?B?ckpqL0FidCtUSmIvUFVXaStMOVZsMUVFbnFEVnNpYjVDMXNoTEhMNTdJTm95?= =?utf-8?B?MUlWRlhIakE3SzNyMDYxOGNQb08yalJaRmt0ZFN0NnRDaUR6czRkbkxTUmhN?= =?utf-8?B?VFd1cGRubDJRR05BYlZDNmNSVHVEdzcrMGF2SkRtcnBFNFRYMVliR2I2TjJR?= =?utf-8?B?QUdyUDBwTnZCVzl0emo4MUVPaXdYZDlRNGkvMjd1OTNyN1F5amdVRVNWZERB?= =?utf-8?B?V2NxS0x4c3ZmMkl5U2ZoVUFVWnJjaTZ1bGRoUVhub1RhLzJCUjlhdXhQTXV2?= =?utf-8?B?dStCemw2d2ZhSC9kak16QnVLRFduWVZ0djh0YitLY2ZWME42SGI1MWNsbEY0?= =?utf-8?B?QVhnTXBsSmJpNEN3cWQ4NEJNK0RNZHFMd0l0OW12Y0ZsQ3pGeDlrM1VFOFND?= =?utf-8?B?VTBHNVpSUGhuaFBIVDk2SkdLZmY1bmZONHE1TGM4czFwZVJzcjhiR1QwMGJm?= =?utf-8?B?TzZtc21sR0xLTENua1dpVWhLMjRFdUpJKzU4a1IrSHZORXQ4L29kM0F2MlBE?= =?utf-8?B?cUNFWVBzMjZUdXRmQmc2aTRVRjBzZUYvd3ZYazhZNGFiWUdSMVE4em1uNjJq?= =?utf-8?B?SmtZV1lvMEVSTXdYaXpjcXhaT0IwRC9vd09zWUtIWlZFVmUvSnlNNS9IN0xZ?= =?utf-8?B?eW05MVRhR0w0dElzQmNQYWxBcXMvYVQ3ZXVmTEJNQ3NaQjhIalRGYUgyU3ZX?= =?utf-8?B?c0pQSUpadkNRV0hhdVM5RDJnYXVYeWEzdmd4SEwraVJkVkxDbnJlbnErNEpN?= =?utf-8?B?K3IrUkR6aEcyL2VFVy9YUUd5TFk5WjJEQjlicnVrNlVabHM0RGFxKytwZzdB?= =?utf-8?B?Ump1dGRIU0JKa3dzMmRRb3pycFBMYS9yK2FVQWU5WlBhNjZNbUtLeFBqY3Z3?= =?utf-8?B?WjEyZ1ZEYjFtNlN0NVBVeHdJQlQ4WDJVenBnWFF5UDY0blBvam95QmhGM296?= =?utf-8?B?NmIvZ0xMSVdmTDVtTGR4ejNvbFBlcDBabGdRNHpiRWdlRFdpYUllcDFVM1Bu?= =?utf-8?B?WWZab0wzZTR5RGduKytpdStHY3NJa2xtK1c0ZEp3Vk9zMWFOWFA5RjlLZUdW?= =?utf-8?B?UXhYNDRmV3h5aW01WG1KM3dONmFuVWNZR2MwQ0gvRnV5V3NGaG5zVGgzTEVK?= =?utf-8?B?NEpBbFNQUUlYOGtEb2Z2bWhocEdDaS9hbTdLZ3NSY094MlNwdXhvMEZqM1N6?= =?utf-8?B?RE03RFAzSmxnWDRvTk1BVlBTNVcvRzFlMFZSZEl2akpKSUxDTzhiUWtBTnFj?= =?utf-8?B?dmRYZ0wvd0dQNXAzRUVZNVFoN251L0NZeGZ6MmVBb2lyODkwMlVUUm5UaEtB?= =?utf-8?B?TElaUmFiS2FkNzZ1eXloVVRQaDBOWjdscFBNeUpqM05pa25KcU5la3UwRzly?= =?utf-8?B?c1B6Y0Y5MjR2TklTSktvRjBlU0Rla0VMelQ4Rnoya1Y4cm1DNE5GM3VKMjFq?= =?utf-8?B?MmRSSXhBdmxhN3kvdmdQWWh5WHRxSlkxT1FJNlg3NS9HamhHUGRaa1RUbEFu?= =?utf-8?B?S1U3eHZObks4Yld2dTBzY0s5TkJmTmtKVERuV3pNem9xbVlNVE1SbnlmZldU?= =?utf-8?B?V3RRbUdOMmZ0Nldjd092N3JtanpNY2w3dE5vclBFdERYRElnajZPL1h1Sngx?= =?utf-8?B?TmJsWmRvdVdOQWRFSFZzMkFYQWVSKzVBL24yb21sWVhKMTBqVFBJZWdFY0k1?= =?utf-8?B?aGVNWXpHb2R0cndyRmpsdk1Na2tHRmVsYXJNbTF4cjFSYkF1Mk5YV3ZVWGdr?= =?utf-8?B?a1B6WmEyN0FhOC9HeHY0cVREWjh0ZmNvYlRaVXNZa1FyZHF1YkNqOXVLbXhT?= =?utf-8?Q?eVOsidD1ZuMcx345CYIIRQOQP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71d462bf-af07-4943-24ff-08dc3f94736c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 17:23:20.5772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpBOOcj7GrCZQJhJO7OEpdXusu2whTMrfnXtOyqXl26udDtie8Y0kIBYTRpSl1Ha X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7829 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > In case the application enables fast mbuf release optimization, > the driver releases 256 TX mbufs in bulk upon reaching the > TX free threshold. > The existing implementation utilizes rte_mempool_put_bulk for bulk > freeing TXs, which exclusively supports direct mbufs. > In case the application transmits indirect bufs, the driver must > also decrement the mbuf reference count and unlink the mbuf segment. > For such case, the driver should employ rte_pktmbuf_free_bulk. > Ack. I wonder if you observe any performance impact from this change, just for reference if we encounter similar decision in the future.