From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 706E21B213 for ; Tue, 12 Feb 2019 17:21:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DDC4323590; Tue, 12 Feb 2019 11:21:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 11:21:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LUVq/9o9W1tEyWGbSId4jK/Wb03d1qs/LlFie5Ix0Ls=; b=NQvYohctfV5r DeB5BIXCuUrUM2M9st2YIZcRorJR4eRTzBkULEyogG1lH+/Y02Q9STyDumQA4V5c V0VTwRBxdjzyLQTB2STUi+9z7VTH8l9GMfcDx5v7LQKQzk0rrOqN7y+FoJ4ZNC3A vd8Q+Z30Dz3MscXGB86b3jsc1neRTSo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LUVq/9o9W1tEyWGbSId4jK/Wb03d1qs/LlFie5Ix0 Ls=; b=kjYzRErHrT5kEHtqkJlxEGeSS9sO+l68DgqT9B1Dmc6xyUxYuPg2eLZwq XHu4d/O1UsR/c4yAgPGOG74/RJsGcL935mELcSCcwdb/RzHYfLlQDfK2CL71R1a8 gfJZdReyP95ftrfU9GRUSc4mFBpoi6Iy4ZIImjBFx3Ct1/kHWK7kKRgQWjpiUIVS RHhEQfvbZTvslakMa1LZ55T9fSfc8qvc5t96LXRQOzpsJVNhz8bVCdxh1wRCfsHP Ok/7bkJxS21Xb5yV+AZIt7T3wzp7Dq9ze96HxZmXo58D7jixy+BSSsQltM+TiK8o JTXHT2EqTnRPxV4iS+cOjzEuK5iMA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtuddgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ADB10E4412; Tue, 12 Feb 2019 11:21:34 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Luca Boccassi Cc: dev@dpdk.org Date: Tue, 12 Feb 2019 17:21:32 +0100 Message-ID: <3052011.MRUk6sNC2W@xps> In-Reply-To: <20190212150318.GC517812@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <2701171.9Cy1FB2YhE@xps> <20190212150318.GC517812@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 16:21:36 -0000 12/02/2019 16:03, Bruce Richardson: > On Tue, Feb 12, 2019 at 03:47:56PM +0100, Thomas Monjalon wrote: > > 12/02/2019 12:43, Bruce Richardson: > > > On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon wrote: > > > > 12/02/2019 12:31, Bruce Richardson: > > > > > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote: > > > > > > 06/02/2019 18:08, Luca Boccassi: > > > > > > > Whenever possible (if the library ships a pkg-config file) use meson's > > > > > > > dependency() function to look for it, as it will automatically add it > > > > > > > to the Requires.private list if needed, to allow for static builds to > > > > > > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > > > > > > dependencies are not parsed, and users doing static builds have to > > > > > > > resolve them manually by themselves. > > > > > > > When using this API avoid additional checks that are superfluous and > > > > > > > take extra time, and avoid adding the linker flag manually which causes > > > > > > > it to be duplicated. > > > > > > > > > > > > > > Signed-off-by: Luca Boccassi > > > > > > > Acked-by: Bruce Richardson > > > > > > > > > > > > This patch breaks compilation on my machine with a lot of strange errors: > > > > > > > > > > > > from drivers/net/pcap/rte_eth_pcap.c > > > > > > > > > > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > > > > > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' qualifier from pointer target type > > > > > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored > > > > > > etc > > > > > > > > > > > Is this on Arch linux again? I just reverified these first two patches and > > > > > they work fine for me on Fedora (I assume Luca probably tested them already on > > > > > Debian) > > > > > > > > > > Anything unusual about your setup? > > > > > > > > Nothing unusual. Just using the best environment ever ;) > > > > I will try to debug it. > > > > > > > It may be something pcap-specific, since pcap has to have it's own special > > > query mechanims outside the normal pkg-config one. If you remove the > > > pcap-driver changes, does the rest of the patch work for you? > > > > Yes, the issue happens only with pcap on Arm. > > Reverting the pcap related changes, it builds fine. > > > > More infos about my setup: > > meson-0.49.1 > > aarch64-linux-gnu-gcc-8.2.0 > > libpcap-1.9.0 (32 and 64-bit) for x86 > > > > I think there is a mix between libcap for x86 and Arm compilation. > > Probably a meson bug? > > > Could well be a meson issue. It may be using the local pcap-config rather > than the cross-compilation version [assuming cross-compilation here, though > I don't see the issue with my setup]. > > Thomas, can you apply this set with the pcap driver change dropped, > or is it better if Luca does a new version of this set? I think we need a comment about the pcap miss. Probably better to do a new version. Luca, please could you test cross-compilation?