DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jincheng Miao <jmiao@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: replace strict_strtoul with kstrtoul
Date: Fri, 28 Nov 2014 17:45:47 +0100
Message-ID: <3056498.fK5yQdOQol@xps13> (raw)
In-Reply-To: <1414741039-3531-3-git-send-email-jmiao@redhat.com>

2014-10-31 15:37, Jincheng Miao:
> From upstream kernel commit 3db2e9cd, strict_strto* serial functions
> are removed. So that we should directly used kstrtoul instead.
> 
> For compatible with old kernel and RHEL6, add some logic to
> igb_uio/compat.h, same as what we do for pci_num_vf().
> 
> Signed-off-by: Jincheng Miao <jmiao@redhat.com>
> ---
>  lib/librte_eal/linuxapp/igb_uio/compat.h        |    8 ++++++++
>  lib/librte_eal/linuxapp/igb_uio/igb_uio.c       |    4 ++--
>  lib/librte_eal/linuxapp/kni/kni_vhost.c         |    2 +-
>  lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c |    2 +-

You are replacing strict_strtoul in kni and xen_dom0 without providing
a compatibility fallback.

-- 
Thomas

      reply	other threads:[~2014-11-28 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  7:37 [dpdk-dev] [PATCH v2 0/2] compatibility fallback and replacement of kernel function invoking Jincheng Miao
2014-10-31  7:37 ` [dpdk-dev] [PATCH v2 1/2] igb_uio: compatible with upstream longterm kernel and RHEL6 Jincheng Miao
2014-11-27 17:01   ` Thomas Monjalon
2014-11-28  8:13     ` Jincheng Miao
2014-11-28 16:42       ` Thomas Monjalon
2014-12-02  4:01         ` Jincheng Miao
2014-10-31  7:37 ` [dpdk-dev] [PATCH v2 2/2] eal: replace strict_strtoul with kstrtoul Jincheng Miao
2014-11-28 16:45   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3056498.fK5yQdOQol@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jmiao@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git