From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id C3DC43F9 for ; Fri, 28 Nov 2014 17:46:10 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id l15so11757225wiw.10 for ; Fri, 28 Nov 2014 08:46:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KQoH0n8wKjzG2L5nVz2no5pVij1qrDDo69hzVg7YBSM=; b=lGJCetRH/NzDMPjSNsHazrVZ9xg8FYlR+bTF53NvEaMVM1XVA8SQj4tfIGjAgXyVQo LtmbFRPoOBVTDKhpipx903SCT0kA16KaFRkzyiS3izHKPQehL7Wr6aYcpx4P9sHJ6V+m 2qjTPYza1kscmRAfzagjE+gyjHpp4lk9RrvXCz0uD6WwhcI9GITeM9STcb5tqhSQL+D3 zms4jMqZ30OXZppWzvHwW4K1Ri4ksnJtVx3ofOlinWqvYYZ0plrc7l361oebbZbQ0n8F EFmBi205QzoUT5GHJxKDD3oYXMTMccWLNkzWmt328LErWyfTVqC9Ux/d07+naIEN8P5b j+ag== X-Gm-Message-State: ALoCoQk90qeOwwzHhdqQO6CDEo1vcqDfdZJPGHw+Txk5Pogfr+e5RDb7o9r0DhcONV21dk7sqf1E X-Received: by 10.194.156.138 with SMTP id we10mr16083488wjb.72.1417193170604; Fri, 28 Nov 2014 08:46:10 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id v6sm15680499wjz.40.2014.11.28.08.46.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Nov 2014 08:46:09 -0800 (PST) From: Thomas Monjalon To: Jincheng Miao Date: Fri, 28 Nov 2014 17:45:47 +0100 Message-ID: <3056498.fK5yQdOQol@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1414741039-3531-3-git-send-email-jmiao@redhat.com> References: <1414741039-3531-1-git-send-email-jmiao@redhat.com> <1414741039-3531-3-git-send-email-jmiao@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: replace strict_strtoul with kstrtoul X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 16:46:11 -0000 2014-10-31 15:37, Jincheng Miao: > From upstream kernel commit 3db2e9cd, strict_strto* serial functions > are removed. So that we should directly used kstrtoul instead. > > For compatible with old kernel and RHEL6, add some logic to > igb_uio/compat.h, same as what we do for pci_num_vf(). > > Signed-off-by: Jincheng Miao > --- > lib/librte_eal/linuxapp/igb_uio/compat.h | 8 ++++++++ > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 ++-- > lib/librte_eal/linuxapp/kni/kni_vhost.c | 2 +- > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 2 +- You are replacing strict_strtoul in kni and xen_dom0 without providing a compatibility fallback. -- Thomas