From: Thomas Monjalon <thomas@monjalon.net> To: Ori Kam <orika@mellanox.com> Cc: jerinj@marvell.com, xiang.w.wang@intel.com, matan@mellanox.com, viacheslavo@mellanox.com, John McNamara <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, Parav Pandit <parav@mellaox.com>, Shahaf Shuler <shahafs@mellanox.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, guyk@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com, hemant.agrawal@nxp.com, opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, bruce.richardson@intel.com, yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, jim@netgate.com, hongjun.ni@intel.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com, rasland@mellanox.com, Yuval Avnery <yuvalav@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver Date: Mon, 20 Jul 2020 00:15:55 +0200 Message-ID: <3058241.yiR4NS12MS@thomas> (raw) In-Reply-To: <1595182154-36508-2-git-send-email-orika@mellanox.com> 19/07/2020 20:09, Ori Kam: > From: Yuval Avnery <yuvalav@mellanox.com> > > This commit introduce the RegEx pull mode drivers class, and > adds Mellanox RegEx PMD. [...] > --- /dev/null > +++ b/doc/guides/regexdevs/features_overview.rst > @@ -0,0 +1,100 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2020 Mellanox Technologies, Ltd SPDX is not aligned with the Copyright. You should not have a double space before SPDX. [...] > --- /dev/null > +++ b/doc/guides/regexdevs/index.rst > @@ -0,0 +1,15 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2020 Mellanox Technologies, Ltd Same here. RST annotations start at the third column. > + > +REGEX Device Drivers > +==================== > + > +The following are a list of RegEx (Regular Expression) device drivers, > +which can be used from an application through RegEx API. > + > +.. toctree:: > + :maxdepth: 2 > + :numbered: same here [...] > + Due to external dependencies, this driver is disabled in default > + configuration of the "make" build. It can be enabled with > + ``CONFIG_RTE_LIBRTE_MLX5_REGEX_PMD=y`` or by using "meson" build system which > + will detect dependencies. I would drop this part. I don't think it is an useful info, especially because make is going to be removed. > +Mellanox mlx5 PCI device can be probed by number of different pci devices, for example Inconsistency on the same line: "pci" vs "PCI". Better to break line after the comma and after a dot. > +net / vDPA / RegEx. To select the RegEx PMD ``class=regex`` should be specified > +as device parameter. This does not explain if RegEx is exclusive with other classes. [...] > +- BlueField 2 running Mellonx supported kernel. typo: Mellonx > +- Enable the RegEx caps using system call from the BlueField 2. This is a doc. Please write full words: "capabilities". [...] > +These options can be modified in the ``.config`` file. > + > +- ``CONFIG_RTE_LIBRTE_MLX5_REGEX_PMD`` (default **n**) > + > + Toggle compilation of librte_pmd_mlx5 itself. Better to drop this "make" part. [...] > enum mlx5_class { > MLX5_CLASS_INVALID, > MLX5_CLASS_NET = RTE_BIT64(0), > + MLX5_CLASS_REGEX = RTE_BIT64(2), > MLX5_CLASS_VDPA = RTE_BIT64(1), I think regex would be better sorted after vDPA. [...] > +++ b/drivers/regex/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2020 Mellanox Technologies, Ltd > + > +drivers = ['mlx5'] > +std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc > +std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std > +std_deps += ['bus_vdev'] # same with vdev bus I disagree about making bus some standard deps.
next prev parent reply other threads:[~2020-07-19 22:16 UTC|newest] Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-05 9:23 [dpdk-dev] [PATCH 00/20] add Mellanox RegEx PMD Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver Ori Kam 2020-07-05 10:59 ` Wang, Haiyue 2020-07-05 11:32 ` Ori Kam 2020-07-06 22:47 ` Thomas Monjalon 2020-07-05 9:23 ` [dpdk-dev] [PATCH 02/20] regex/mlx5: add log utils Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 03/20] common/mlx5: add MMO and regexp structs/opcodes Ori Kam 2020-07-08 7:32 ` Slava Ovsiienko 2020-07-05 9:23 ` [dpdk-dev] [PATCH 04/20] common/mlx5: add mlx5 regex command structs Ori Kam 2020-07-08 7:32 ` Slava Ovsiienko 2020-07-05 9:23 ` [dpdk-dev] [PATCH 05/20] common/mlx5: add support for regex capability query Ori Kam 2020-07-08 7:32 ` Slava Ovsiienko 2020-07-05 9:23 ` [dpdk-dev] [PATCH 06/20] regex/mlx5: add probe function Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 07/20] common/mlx5: add rxp database set cmd Ori Kam 2020-07-08 7:32 ` Slava Ovsiienko 2020-07-05 9:23 ` [dpdk-dev] [PATCH 08/20] regex/mlx5: add RXP register definitions Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 09/20] common/mlx5: add write and read RXP registers Ori Kam 2020-07-08 7:32 ` Slava Ovsiienko 2020-07-05 9:23 ` [dpdk-dev] [PATCH 10/20] regex/mlx5: add engine status check Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 11/20] regex/mlx5: add get info function Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 12/20] regex/mlx5: add configure function Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 13/20] regex/mlx5: add program rules support Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 14/20] regex/mlx5: add completion queue creation Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 15/20] regex/mlx5: add send queue support Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 16/20] common/mlx5: add match tuple hw layout Ori Kam 2020-07-08 7:32 ` Slava Ovsiienko 2020-07-05 9:23 ` [dpdk-dev] [PATCH 17/20] regex/mlx5: fastpath setup Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 18/20] regex/mlx5: add enqueue implementation Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 19/20] regex/mlx5: implement dequeue function Ori Kam 2020-07-05 9:23 ` [dpdk-dev] [PATCH 20/20] maintainers: add maintainers to regexdev lib Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 00/20] add Mellanox RegEx PMD Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 01/20] regex/mlx5: add RegEx PMD layer and mlx5 driver Ori Kam 2020-07-15 17:20 ` Thomas Monjalon 2020-07-15 17:29 ` Thomas Monjalon 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 02/20] regex/mlx5: add log utils Ori Kam 2020-07-15 17:32 ` Thomas Monjalon 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 03/20] common/mlx5: add MMO and regexp structs/opcodes Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 04/20] common/mlx5: add mlx5 regex command structs Ori Kam 2020-07-15 17:24 ` Thomas Monjalon 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 05/20] common/mlx5: add support for regex capability query Ori Kam 2020-07-15 17:26 ` Thomas Monjalon 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 06/20] regex/mlx5: add probe function Ori Kam 2020-07-15 17:38 ` Thomas Monjalon 2020-07-15 19:02 ` Thomas Monjalon 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 07/20] common/mlx5: add rxp database set cmd Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 08/20] regex/mlx5: add RXP register definitions Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 09/20] common/mlx5: add write and read RXP registers Ori Kam 2020-07-15 17:34 ` Thomas Monjalon 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 10/20] regex/mlx5: add engine status check Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 11/20] regex/mlx5: add get info function Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 12/20] regex/mlx5: add configure function Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 13/20] regex/mlx5: add program rules support Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 14/20] regex/mlx5: add completion queue creation Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 15/20] regex/mlx5: add send queue support Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 16/20] common/mlx5: add match tuple hw layout Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 17/20] regex/mlx5: fastpath setup Ori Kam 2020-07-12 20:58 ` [dpdk-dev] [PATCH v2 18/20] regex/mlx5: add enqueue implementation Ori Kam 2020-07-12 20:59 ` [dpdk-dev] [PATCH v2 19/20] regex/mlx5: implement dequeue function Ori Kam 2020-07-12 20:59 ` [dpdk-dev] [PATCH v2 20/20] regex/mlx5: add start stop functions Ori Kam 2020-07-15 16:48 ` [dpdk-dev] [PATCH v2 00/20] add Mellanox RegEx PMD Thomas Monjalon 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 00/13] " Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 02/13] regex/mlx5: add log utils Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 03/13] regex/mlx5: add probe function Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 04/13] regex/mlx5: add get info function Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 05/13] regex/mlx5: add engine status check Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 06/13] regex/mlx5: add configure function Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 07/13] regex/mlx5: add program rules support Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 08/13] regex/mlx5: add completion queue creation Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 09/13] regex/mlx5: add send queue support Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 10/13] regex/mlx5: fastpath setup Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 11/13] regex/mlx5: add enqueue implementation Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 12/13] regex/mlx5: implement dequeue function Ori Kam 2020-07-17 10:27 ` [dpdk-dev] [PATCH v3 13/13] regex/mlx5: add start stop functions Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 00/13] add Mellanox RegEx PMD Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 02/13] regex/mlx5: add log utils Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 03/13] regex/mlx5: add probe function Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 04/13] regex/mlx5: add get info function Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 05/13] regex/mlx5: add engine status check Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 06/13] regex/mlx5: add configure function Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 07/13] regex/mlx5: add program rules support Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 08/13] regex/mlx5: add completion queue creation Ori Kam 2020-07-17 11:10 ` [dpdk-dev] [PATCH v4 09/13] regex/mlx5: add send queue support Ori Kam 2020-07-17 11:11 ` [dpdk-dev] [PATCH v4 10/13] regex/mlx5: fastpath setup Ori Kam 2020-07-17 11:11 ` [dpdk-dev] [PATCH v4 11/13] regex/mlx5: add enqueue implementation Ori Kam 2020-07-17 11:11 ` [dpdk-dev] [PATCH v4 12/13] regex/mlx5: implement dequeue function Ori Kam 2020-07-17 11:11 ` [dpdk-dev] [PATCH v4 13/13] regex/mlx5: add start stop functions Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 00/13] add Mellanox RegEx PMD Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver Ori Kam 2020-07-19 22:15 ` Thomas Monjalon [this message] 2020-07-20 4:50 ` Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 02/13] regex/mlx5: add log utils Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 03/13] regex/mlx5: add probe function Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 04/13] regex/mlx5: add get info function Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 05/13] regex/mlx5: add engine status check Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 06/13] regex/mlx5: add configure function Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 07/13] regex/mlx5: add program rules support Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 08/13] regex/mlx5: add completion queue creation Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 09/13] regex/mlx5: add send queue support Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 10/13] regex/mlx5: fastpath setup Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 11/13] regex/mlx5: add enqueue implementation Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 12/13] regex/mlx5: implement dequeue function Ori Kam 2020-07-19 18:09 ` [dpdk-dev] [PATCH v5 13/13] regex/mlx5: add start stop functions Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 00/13] add Mellanox RegEx PMD Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 02/13] regex/mlx5: add log utils Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 03/13] regex/mlx5: add probe function Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 04/13] regex/mlx5: add get info function Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 05/13] regex/mlx5: add engine status check Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 06/13] regex/mlx5: add configure function Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 07/13] regex/mlx5: add program rules support Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 08/13] regex/mlx5: add completion queue creation Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 09/13] regex/mlx5: add send queue support Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 10/13] regex/mlx5: fastpath setup Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 11/13] regex/mlx5: add enqueue implementation Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 12/13] regex/mlx5: implement dequeue function Ori Kam 2020-07-20 6:26 ` [dpdk-dev] [PATCH v6 13/13] regex/mlx5: add start stop functions Ori Kam 2020-07-21 17:06 ` [dpdk-dev] [PATCH v6 00/13] add Mellanox RegEx PMD Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3058241.yiR4NS12MS@thomas \ --to=thomas@monjalon.net \ --cc=alexr@mellanox.com \ --cc=arthur.su@lionic.com \ --cc=bruce.richardson@intel.com \ --cc=davidfgao@tencent.com \ --cc=deri@ntop.org \ --cc=dev@dpdk.org \ --cc=dovrat@marvell.com \ --cc=fanchenggang@sunyainfo.com \ --cc=fc@napatech.com \ --cc=gu.jian1@zte.com.cn \ --cc=guyk@marvell.com \ --cc=harry.chang@intel.com \ --cc=hemant.agrawal@nxp.com \ --cc=hongjun.ni@intel.com \ --cc=jerinj@marvell.com \ --cc=jim@netgate.com \ --cc=john.mcnamara@intel.com \ --cc=liuzhong1@chinaunicom.cn \ --cc=lixingfu@huachentel.com \ --cc=marko.kovacevic@intel.com \ --cc=matan@mellanox.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=nipun.gupta@nxp.com \ --cc=oc@yunify.com \ --cc=opher@mellanox.com \ --cc=orika@mellanox.com \ --cc=parav@mellaox.com \ --cc=pbhagavatula@marvell.com \ --cc=pkapoor@marvell.com \ --cc=rasland@mellanox.com \ --cc=shahafs@mellanox.com \ --cc=shanjiangh@chinatelecom.cn \ --cc=viacheslavo@mellanox.com \ --cc=wushuai@inspur.com \ --cc=xiang.w.wang@intel.com \ --cc=yang.a.hong@intel.com \ --cc=yuvalav@mellanox.com \ --cc=yuyingxia@yxlink.com \ --cc=zhangy.yun@chinatelecom.cn \ --cc=zhaoyong11@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git