From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5E5021B553 for ; Fri, 29 Jun 2018 13:57:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94E3F21ADD; Fri, 29 Jun 2018 07:57:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 29 Jun 2018 07:57:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Oo95gxM1ygWjhCVgIf9gl7s4nS Tu0dTkug0ZOOrXJzM=; b=IGDcCXTUTGYHYUO3erbFajP6KC+ARZIqO7pEqJTOiO WqROCPD5Jh2Ua+oI9lTKhPwoaMIpSujcP40kHY0rppryDmZ2FI9QyOueFRaRT/3f fqdNXqwxXqeplkl6C7gyANCmGuadsDcBg3mFDV3Sv4w9SUUf5pqiqhTCyVmfzMmT Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Oo95gx M1ygWjhCVgIf9gl7s4nSTu0dTkug0ZOOrXJzM=; b=wLsJ6FSOuSRXJOaJ5QXeye iWMvlyLc+p6bbQgAXxznFJ+OBmnTbW4YpP5u/o7xXUoGCV4ra3aET7zkIe+458Pq 48uM9dvTk7dXltq82q2Kg/WGMJDDmfo63TCLKGqRB9YFSsmfZfEGj2FrB2vKs8dW vhD5NGaY7KQ3dq3j1JI7D0eDfJp3q3TZ1b6wgzEmbExoWQfwo0QxYmZ5Unyia4uy kd+6bq1vgzxzUtL+GEnvRE5N+dtVaj9E01V6Y2nMLSjHstv+/fY0QPMD6KdEjlFB vneybfsr7nWjOyOhYqo14CDimfy8AZ04qcIea3xY8U2EDpkJDxBr/pB/OMVn+Y5A == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D02C91042F; Fri, 29 Jun 2018 07:57:29 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic , "John W. Linville" , Allain Legacy , Matt Peters , Ravi Kumar , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Wenzhuo Lu , Qi Zhang , Xiao Wang , Beilei Xing , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Tomasz Duszynski , Dmitri Epshtein , Natalie Samsonov , Jianbo Liu , Alejandro Lucero , Tetsuya Mukawa , Santosh Shukla , Jerin Jacob , Rasesh Mody , Harish Patil , Shahed Shaikh , Bruce Richardson , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Matej Vido , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang Date: Fri, 29 Jun 2018 13:57:28 +0200 Message-ID: <306055545.4tjrTrjsPy@xps> In-Reply-To: <20180629124113.65856-1-ferruh.yigit@intel.com> References: <20180621131500.22460-1-ferruh.yigit@intel.com> <20180629124113.65856-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: add new offload flag to keep CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 11:57:36 -0000 29/06/2018 14:41, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag is added. PMDs that support > keeping CRC should advertise this offload capability. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release > default behavior in PMDs are to keep the CRC until this flag removed > > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Setting both KEEP_CRC & CRC_STRIP is INVALID > - Setting only CRC_STRIP PMD should strip the CRC > - Setting only KEEP_CRC PMD should keep the CRC > - Not setting both PMD should keep the CRC > > A helper function rte_eth_dev_is_keep_crc() has been added to be able to > change the no flag behavior with minimal changes in PMDs. > > The PMDs that doesn't report the DEV_RX_OFFLOAD_KEEP_CRC offload can > remove rte_eth_dev_is_keep_crc() checks next release, related code > commented to help the maintenance task. > > And DEV_RX_OFFLOAD_CRC_STRIP has been added to virtual drivers since > they don't use CRC at all, when an application requires this offload > virtual PMDs should not return error. > > Signed-off-by: Ferruh Yigit > Acked-by: Allain Legacy > Acked-by: Andrew Rybchenko Acked-by: Thomas Monjalon