From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: xuelin.shi@freescale.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] librte_lpm: define tbl entry reversely for big endian
Date: Fri, 10 Jul 2015 23:23:10 +0200 [thread overview]
Message-ID: <3064017.UErnQxGTeU@xps13> (raw)
In-Reply-To: <20150519100559.GA11036@bricha3-MOBL3>
2015-05-19 11:05, Bruce Richardson:
> On Tue, Mar 24, 2015 at 01:58:20PM +0800, xuelin.shi@freescale.com wrote:
> > From: Xuelin Shi <xuelin.shi@freescale.com>
> >
> > This module uses type conversion between struct and int.
> > Also truncation and comparison is used with this int.
> > It is not safe for different endian arch.
> >
> > Add ifdef for big endian struct to fix this issue.
> >
> > Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
>
> Since nobody objects to this patch, and it looks ok to me:
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-07-10 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 5:58 xuelin.shi
2015-05-19 10:05 ` Bruce Richardson
2015-07-10 21:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3064017.UErnQxGTeU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=xuelin.shi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).