From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5F5F4326D for ; Thu, 26 Jul 2018 11:35:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C91DE21F5F; Thu, 26 Jul 2018 05:35:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 05:35:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LGihou32F/R924HfT2K5ak76Vt D5LiDUQCXeqFj3tQ0=; b=IwUzKlc1o1KQX864oD6DpeBQ+TBXxdXMs4QvmltdVi w4WGXpBaz9loJvPEyjfd3STOJMFxT/Zj5h4Giv4vTMasxYO84RH1jLXBu8TEANGN ZxA4V6mk1p1c7hzWyRBaAsM6iYGWnCWUlSNeopN54gujwaQ9sNLv7yxHWuJrovSQ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=LGihou 32F/R924HfT2K5ak76VtD5LiDUQCXeqFj3tQ0=; b=a6nHVDbRFlCpgW+J7VXrWS oL9tp/WAm8h70kfUsKtm85slqV4exA8rJOmbsJSVYONyJ0qvI96r4VutCumnDuZT SXqs9xfPVwKmnxauGXA+WiylEOWr2NBu56IqN23ms9oDrlFPbpW5IWyqRjVI0e3F vrMgPXMXgl5v2OcH+JAJYUImSRYphK0nmBBrX9xFWOwv/Wb9zBhvQdNxuEWIPua3 xP3nV6SclOEAzhW3Y/l3tWKdJWdeU6vObHcEatFEbFygHezdqItONRmIME1JperA HR2aT+aXtZkdDG8fqz5qv8ozXxGswQ4JsPfHCWyz20g7IjV4cfh0VoepxLEQu08w == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B83610292; Thu, 26 Jul 2018 05:35:48 -0400 (EDT) From: Thomas Monjalon To: Takeshi Yoshimura Cc: dev@dpdk.org, Anatoly Burakov Date: Thu, 26 Jul 2018 11:35:43 +0200 Message-ID: <30652783.zuAJVELDdt@xps> In-Reply-To: <20180720081347.6123-1-t.yoshimura8869@gmail.com> References: <20180712030833.4887-1-t.yoshimura8869@gmail.com> <20180720081347.6123-1-t.yoshimura8869@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 09:35:50 -0000 20/07/2018 10:13, Takeshi Yoshimura: > Currently, VFIO will try to map around MSI-X table in the BARs. When > MSI-X table (page-aligned) size is equal to (page-aligned) size of BAR, > VFIO will just skip the BAR. > > Recent kernel versions will allow VFIO to map the entire BAR containing > MSI-X tables (*), so instead of trying to map around the MSI-X vector > or skipping the BAR entirely if it's not possible, we can now try > mapping the entire BAR first. If mapping the entire BAR doesn't > succeed, fall back to the old behavior of mapping around MSI-X table or > skipping the BAR. > > (*): "vfio-pci: Allow mapping MSIX BAR", > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ > commit/?id=a32295c612c57990d17fb0f41e7134394b2f35f6 > > Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables") > > Signed-off-by: Takeshi Yoshimura > Reviewed-by: Anatoly Burakov Applied, thanks