DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mem: improve parameter checking on memory hotplug
Date: Mon, 18 Jan 2021 11:37:36 +0000
Message-ID: <306a8459-0bc0-d8b8-1c78-749d68560ef6@intel.com> (raw)
In-Reply-To: <CAJFAV8yC3O83gUBjSCtEHv6SifV6czrLz4rn1erjF0yy8BituQ@mail.gmail.com>

On 18-Jan-21 8:26 AM, David Marchand wrote:
> On Fri, Jan 15, 2021 at 1:15 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>>
>> Currently, we don't check anything that comes in through memory hotplug
>> subsystem using the IPC, because we always assume the data is correct.
>> This is okay as anyone having access to the IPC socket would also have
>> rights to crash the DPDK process through other means, but it's still a
>> good practice to do parameter checking, so fix the code to do that.
> 
> Intel CI and GHA caught an issue on 32bits builds:
> https://github.com/ovsrobot/dpdk/runs/1708623050?check_suite_focus=true#step:14:558
> 

Yep, saw that, will fix.

-- 
Thanks,
Anatoly

  reply	other threads:[~2021-01-18 11:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 12:15 Anatoly Burakov
2021-01-18  8:26 ` David Marchand
2021-01-18 11:37   ` Burakov, Anatoly [this message]
2021-01-18 15:41 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2021-01-19 23:39   ` Thomas Monjalon
2021-01-21 10:52     ` Burakov, Anatoly
2021-01-22 17:17   ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2021-01-27 13:23     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=306a8459-0bc0-d8b8-1c78-749d68560ef6@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git