From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id DD391BE7C for ; Fri, 3 Apr 2015 15:58:23 +0200 (CEST) Received: by wizk4 with SMTP id k4so45103269wiz.1 for ; Fri, 03 Apr 2015 06:58:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2W9C4Xj4ZPvdy5BVPQBPAIf6lG1tyVMquA2xQYALYZ4=; b=BSKEsSgPZCuB5tK4N/Eq40fAJhHXhM0csRR7iWh2UEpHLtIllkXjkSPCSwmaS7Cs7/ NVmztARcvEC/wuOAkzR1M33SUp7PiOuMXO11gECAoy760NYJDt+F02SgvXc2qpkc2g6k o2ceDsjWQCEqNXXZAjPFN7tWbfhTfzmOmkwAXc5SutlacHtjNVdC9G/UnaW4yqIKxoxw dvsRdMH+IjKPNpdEAzXi3/713HCEzQEEzKQ7bAi6wOaKrX5V/jpRZJYd2kzRzcFnl6OR DkmUDYjonugU/eKNzk3bX0SrqmpBx+r5RzEAKhIvJ7fjj/oCEqZ5HKgqff/XIP2KoGl2 cWHA== X-Gm-Message-State: ALoCoQmPYxdKQchOGUmvg/cN6RHAHiPI4RDoYuSN0mOSkx6EwqEeJzZxK5cQIlZukIOqyn4CwcTz X-Received: by 10.180.105.74 with SMTP id gk10mr13600536wib.29.1428069503774; Fri, 03 Apr 2015 06:58:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id z13sm11631226wjr.44.2015.04.03.06.58.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Apr 2015 06:58:22 -0700 (PDT) From: Thomas Monjalon To: "Ouyang, Changchun" Date: Fri, 03 Apr 2015 15:57:39 +0200 Message-ID: <3070066.e8G6AS7GDY@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1427824702-5119-1-git-send-email-thomas.monjalon@6wind.com> <2662680.fVrczecCFl@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mbuf: clean old refcnt option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2015 13:58:24 -0000 2015-04-03 05:10, Ouyang, Changchun: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-03-31 21:26, Olivier MATZ: > > > On 03/31/2015 07:58 PM, Thomas Monjalon wrote: > > > > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into > > > > CONFIG_RTE_MBUF_REFCNT by commit 62814bc2e923 and removed by > > commit 4769bc5a27cc. > > > > Some traces remain because of delayed patches. > > > > > > > > It can also be removed from doxygen config. > > > > It is now poisoned in rte_mbuf.h to warn any misuse. > > > > > > > > Fixes: d0dff9ba445e ("doc: sample application user guide") > > > > Fixes: fc1f2750a3ec ("doc: programmers guide") > > > > Fixes: 4769bc5a27cc ("mbuf: remove build option to disable refcnt") > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > I have one doubt about the vhost part, as the previous doc was telling > > > to disable refcnt option and now the behavior is equivalent to having > > > the option always enabled. Also you are removing parts of doc that > > > talk about CONFIG_RTE_LIBRTE_DISTRIBUTOR and > > CONFIG_RTE_LIBRTE_IP_FRAG. > > > > > > It would be safer to also have an acknowledgment from a vhost expert. > > > > Huawei, Changchun, any opinion please? > > Ok to remove it from vhost user doc as the macro in code is removed. > Thanks > Changchun Applied, thanks