From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B62B42D72; Tue, 27 Jun 2023 15:27:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3955940F18; Tue, 27 Jun 2023 15:27:14 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id E0ED140EE1 for ; Tue, 27 Jun 2023 15:27:12 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8A60C5C0064; Tue, 27 Jun 2023 09:27:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 27 Jun 2023 09:27:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687872432; x=1687958832; bh=rFaHLyBo0kCUZ9gqpsd9BLFRnuOMLOXHRMK eyKVGh0s=; b=V0uVJ4BC6dmJRFV0qhLVlUOgicwy4XgjVm8MXtMM/955X5vFWFm 1jVe2AksI+utwy/vbAyfAkaCkQuoZjs+QIO61t4H2rR/ogUpjejEmKiYsmr72+zM W7Ku5bxq+Fh3gKrCn/3HKNOeE5qQiWtgajXYqroqf/yxZB9zStBotEWOhesfaD2R Y+O27qaktugzK7zhyBP35L7ZoZNP6FfL3QE1dbqvH8pseUWJ7t8cNE46UOX0OKu4 Uf2VwIXSD1duLDW8JCK7tNgQ/rLyL6kbXuGPEBbKbmts8VI54GYGm33j0Q0IMoZ7 YVGV2no+IdaWOU8QL9fUvMpz0T07xQ+2HbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687872432; x=1687958832; bh=rFaHLyBo0kCUZ9gqpsd9BLFRnuOMLOXHRMK eyKVGh0s=; b=G0LSc83f8GVpI2IWu6xm+puTLg6x2QcxyhJW1UP+ZdbwyVNDTf+ 3QI642sySmR9g6C14MxXYEp/kHaKM+ELQRlBTjgk4lCxIRk9t03+uUUZQY9WbSsp FTweMDgOPctagbyhlIkY4n8lbwcMAOGTFR3uPI+9ERYGJ7+F6twjEsarxC1E5lpu 3x3rjIDO9avaWZhjA3ga7+zZW26CK494IRZHhOrpy7M+eVOAoNQjH18uz1ylnz2e MEJK1vNgiAUj2WBOBuMlxRVl3LjqcludH8kcfC6st1Yu/9PzJSvAdcrGw13n4h+m UopwGVy16+X8IIQ9i9fDBhVfsMsKEE10ogA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddtgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleffteeh veduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 09:27:11 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand Subject: Re: [PATCH v5] build: prevent accidentally building without NUMA support Date: Tue, 27 Jun 2023 15:27:10 +0200 Message-ID: <3070559.U3zVgo479M@thomas> In-Reply-To: <20230615143854.374384-1-bruce.richardson@intel.com> References: <20230613165839.165887-1-bruce.richardson@intel.com> <20230615143854.374384-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/06/2023 16:38, Bruce Richardson: > When libnuma development package is missing on a system, DPDK can still > be built but will be missing much-needed support for NUMA memory > management. This may later cause issues at runtime if the resulting > binary is run on a NUMA system. > > We can reduce the incidence of such runtime errors by ensuring that, for > native builds*, libnuma is present - unless the user actually specifies > via "max_numa_nodes" that they don't require NUMA support. Having this > as an error condition is also in keeping with what is documented in the > Linux GSG doc, where libnuma is listed as a requirement for building > DPDK [1]. > > * NOTE: cross-compilation builds have a different logic set, with a > separate "numa" value indicating if numa support is necessary. > > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html > > Signed-off-by: Bruce Richardson > Signed-off-by: David Marchand > > --- > V5: Rebase on main, since dependencies merged > > V4: Add Depends-on tag so CI picks up dependency > > V3: > - install 32-bit libnuma packages on CI systems [thanks to David > for the changes] > - split the patch out of the previous patchset, so it can be tracked > separately from the more minor fixup changes. > > V2: Limit check to linux only Is the test ci/Intel-compilation fixed? Could you send a new version for testing the CI?