From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5386AA0350; Wed, 24 Jun 2020 12:44:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EA4B1D8EC; Wed, 24 Jun 2020 12:44:03 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id A1E3A1D8EA for ; Wed, 24 Jun 2020 12:44:01 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 47D3F5800C0; Wed, 24 Jun 2020 06:44:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 24 Jun 2020 06:44:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= JrX+c3Sa7UNkusudSaGvXnvN4MgxuIBIYsy0/ipMmCs=; b=a2LoFQQIhgBvyjNW yk54bp6Sll78MBNkUpE6RTJSWoA10kHfmsj3yshgfmq8rp1DIEz8l0iHVsKAjTBn e93ub+VZfdBU4trvvsHmlysG5+ew1EzIs6y3rTkOOQ2ksylbrM2h8CUiR32RMjuF jnkqsuVfG54cXTidPpXPBu0RRZ+FFpACfD1sLakihyUfo7I9ehS84MMffksIDQMl rKRUglcOAkr+kQ+jB1tPpJKFB7/lo3U73dxL5AP1y17+6zMdnwsDW2IJ8Y0Zq6Qe dmhlXpoYvOvB5KaYUTKWT6XqAcEJxxsgIUGCXIP1Xfc0f/IYMIvp9DWCEiBjZ6A8 Cb1Kfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=JrX+c3Sa7UNkusudSaGvXnvN4MgxuIBIYsy0/ipMm Cs=; b=Fs6UyZApSFf3E7nHR0fL8LCRHx2aQfW5piyc3pdi6r951HKiGGGNml4+o bRCGsw87aV6l0Up4hjZ/ojR3imHEc1Q5WOlAnS7KnRq8LT/ZWuDKtPawQM0o+BTS oJqKO1tIRSJp5+ayloYz4lOnSH0EDdgHAXM6UowbM2v8vovSe5oXMZTZL2kRHqGX yUBCzEAfzSFv4XDIcd2QbIZhaaaPuCqCORf5ZlE9rdKxkS4K3Loh/uWQDNzVguR5 f5iH+eWHBF7oO/hmazuHPkRqR8lkzPObXTkK/qWAy8GghGKi7T03Wpq4eorLJa3D m302yQ8NvjvonOwsVwgOm/l9GSkAA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekjedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C992A3280067; Wed, 24 Jun 2020 06:43:58 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org, chas3@att.com Cc: zhangliang@bigo.sg, chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com, guohongzhi1@huawei.com, luyicai , luyicai , ferruh.yigit@intel.com, matan@mellanox.com, rasland@mellanox.com Date: Wed, 24 Jun 2020 12:43:57 +0200 Message-ID: <3071696.IbEkSYjo7c@thomas> In-Reply-To: <1589887092-26360-1-git-send-email-luyicai@huawei.com> References: <1589887092-26360-1-git-send-email-luyicai@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Any review please? 19/05/2020 13:18, luyicai: > When two host is connected directly without any devices like switch, > and also enable dedicated tx/rx queues on bonding devices slaves, > rx_machine_update would recieving partner lacp negotiation packets, > which partner's port mac filled with zeros. So in this situation, > it would never go rx_machine branch with correct mac! > Thus bond mode 4 will negotiation failed. > > Signed-off-by: luyicai > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index b77a37d..2002ec0 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -798,7 +798,8 @@ > RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); > > partner = &lacp->lacpdu.partner; > - if (rte_is_same_ether_addr(&partner->port_params.system, > + if (rte_is_zero_ether_addr(&partner->port_params.system) || > + rte_is_same_ether_addr(&partner->port_params.system, > &internals->mode4.mac_addr)) { > /* This LACP frame is sending to the bonding port > * so pass it to rx_machine. >