From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75C61A0562; Wed, 14 Apr 2021 23:42:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EEC5161D44; Wed, 14 Apr 2021 23:42:35 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id AAABA161D42 for ; Wed, 14 Apr 2021 23:42:33 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 9CD371339; Wed, 14 Apr 2021 17:42:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 17:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= VpBB55KQS6ZnyrIskaoVA1apy+HPhGiJIt9Q3YVUonU=; b=aoZEk8N+f7CJsvIB /GeW3e5zJS2aD3ijcdies8TPPJG6HGzUGPNj05U7jIT9OzPg5shiPIBHIyjQlfrf WOgvTUFoUXCJjjInJ7rjYVLBm+OO6ZkVbDWsdTOI7s6Z/RtrsISU/8GRpsSIIGCM AKcQGkef1OTuMjnHEhNKGGkqQrB5mY+DGHsgzvyZUEE1H/sOp+xkXq7z8TZfTDcx m0fU4nPov7eXocKlaV+ST4k5sHpAnAx05xOwTeeoyThYiAc5bb6SzfsShKUC86nt cj4J1iaC66+2i4joMNKq94K6LBnxf+5/jLWSM881oMa1bIUprhQqyIBWIjq1bqJa sPVARw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VpBB55KQS6ZnyrIskaoVA1apy+HPhGiJIt9Q3YVUo nU=; b=vOqB8TegItUrWUiY3Q2UA4LnaHa0SPYsMqD55ThxVWnN2quSHJLc9wi35 a2EkM0ZoZ+v3YXDQQFzqp1NiRTo9eazCdjIbF3mhYNRWC+IDJVvAgPWcK1nkpfXz pUR8RSHNSXcDvs8NDGks8wG13VkVuiCm270rjwoUvUGDvhIkGgWqZcP0kDtXwKEM WdoG5QA/IpUSe2vRZoeW96u7aDGoXXSAqmWJ5K9s/CG/5SABTUmlgWmWRY3S5Fd2 I+Kb0eoL+vpj5tcipcw9ul6ikm1fEnFyts+tCuc9i4n3j0mpNIFASk4PfTE60Yju Z1zcBAzmW7w2x48v8McbUE3538RuQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudeiiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 66681240057; Wed, 14 Apr 2021 17:42:31 -0400 (EDT) From: Thomas Monjalon To: Ranjit Menon Cc: Dmitry Kozlyuk , dev@dpdk.org Date: Wed, 14 Apr 2021 23:42:30 +0200 Message-ID: <3072229.f5VMXNVXpi@thomas> In-Reply-To: References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <2549908.9JeyF6cTkx@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2021 23:34, Ranjit Menon: > On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > > 13/04/2021 09:00, Dmitry Kozlyuk: > >> Hi Ranjit, > >> > >> 2021-04-12 21:46 (UTC-0700), Ranjit Menon: > >> [...] > >>> The change to remove the networking shim breaks l2fwd compilation on > >>> Windows, since l2fwd/main.c includes netinet/in.h explicitly. > >>> > >>> How do you propose we fix this, only for Windows? > >> This include is redundant for this file on all platforms, it can be removed. > >> Since -Dexamples=all doesn't work on Windows because of missing dependencies, > >> I wonder which of them need fixing. > > Let's fix the examples which are supported on Windows. > > Other examples may require more updates anyway. > > > Thanks, Thomas. For now, this is only required in l2fwd. Only l2fwd is supported on Windows? > Dmitry, can you please include this in your patch 4/4? Ranjit, if you tell me what exactly is needed, I can do it and merge the series quickly.