From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EA7E2378B for ; Wed, 11 Oct 2017 15:02:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 40A1021335; Wed, 11 Oct 2017 09:02:52 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 11 Oct 2017 09:02:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Snb/vbCigNLdc6xopwnVBcYKuT fgXIwj7bbjVqFvPX8=; b=HEl54veUjcwCgMm0Sbmyv8g/JwOt3ncmrLivqOC+lr hrqvBaKwyHRcUcxc9fBTkl1ha413V7rcCR8tMtWT5RFu73sIXjlKzBHEH8oXs53/ 2is/ZgBBz5HG72Gg8BWWRBKPE7COohywNetbHywUX4ARqTP6baUMEdxIHNTAXYYg c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Snb/vb CigNLdc6xopwnVBcYKuTfgXIwj7bbjVqFvPX8=; b=omjJVo1l+J8UkheKtcZflT vlNNDC4PbEIl5Rd6vrogKHM3yu8M1LjsUz7Ge+iE4TRC14LvWY+K0cw1vtkcSe6x Up0f9hDWKGUvcjKMZu8SfP+mVxyQOt3lfqtzaegxwDGbZV29p69LedSRqpdhRIRM tbK8hBFf2/AkpSoVFisCvm65+1MGLJGVBplcxi7lfaXZjDGTznKlJd/49m123xN2 1veg5JWKDMV3VjjL2m0UTEenod+ifKrxp6FacwMqAbHZ/ftM/9pwzCitMjjHkNEb /I4WU4TyT9S7dmF/rZcyDYwXLez97F8+wlYz6KrsrFgagtEnN365HKHnHFe9v12w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E20D3247AD; Wed, 11 Oct 2017 09:02:51 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Wed, 11 Oct 2017 15:02:51 +0200 Message-ID: <30782747.pV0nTTKWH9@xps> In-Reply-To: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 13:02:54 -0000 07/08/2017 14:04, Jerin Jacob: > baremetal execution environments may have a different > method to enable RTE_INIT instead of using compiler > constructor scheme. Move RTE_INIT* definition under > exec-env to support different execution environments. > > Signed-off-by: Jerin Jacob > --- > app/test-eventdev/evt_test.h | 2 +- > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > lib/librte_eal/common/eal_common_log.c | 2 + > lib/librte_eal/common/include/rte_bus.h | 2 + > lib/librte_eal/common/include/rte_eal.h | 6 --- > lib/librte_eal/common/include/rte_tailq.h | 2 + > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > 9 files changed, 111 insertions(+), 9 deletions(-) > create mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_eal.h > create mode 100644 lib/librte_eal/linuxapp/eal/include/exec-env/rte_eal.h I am not a big fan of duplicating code for Linux and BSD. Maybe we should have different splits and include a common file in Linux and BSD? I feel it would be easier to think about the split when adding a new environment. It is also an open question whether we want to support (again) some bare metal environments.