From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F353FA04DD; Thu, 26 Nov 2020 16:41:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BF15C9CA; Thu, 26 Nov 2020 16:41:37 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 6FFE1C9C4; Thu, 26 Nov 2020 16:41:34 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id ACDE75C00DC; Thu, 26 Nov 2020 10:41:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 26 Nov 2020 10:41:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= RUtNYOgV14zar3wStM7qlcRIqdgdK3ZCxM/4NbWvbVc=; b=gqgcngB0UhHAnIvn aoo8XiwcH9NInsQppgdi27g6r9pT4Z2b4M9LIjM9A82K51ebCnf8GokIZ2Sd0cDA 8HU07zW5IpsIqt5bLQSDhzwW/69Bsj4VrVgF1hAAZlzDEeDpPDRl+cTmSoWryGAL ao6rD6y6yVxQgOHxCfDas3KFrIyWutwrpSyqUwEfZa/Zi/fV0z87b0UVn7szjTkx W2RvlZmdkH8R4R5fSFbkXfur5cclfz82O+ZOtNCUb1IRHRZNmwDi12PLAOPV0zif xHH9Nhlqc1nkwnzpn8017gyWgPMAR9kRCpsJBoO9pMianLj+YdPC5O1/1pvBCmYr oXzJyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=RUtNYOgV14zar3wStM7qlcRIqdgdK3ZCxM/4NbWvb Vc=; b=NB2Ob92f2mgEbYoBlTo9Kg0REeVlI7UUeUM6QBtjO0Uz8aITTaMyREDvP a3X5AUQ6RCEXxnupgSG4mg3qHvGSTnYSa9x+hjhA44Q7C1oAMMS2B5pMgY5wT4UT 0CSGn6HA1EA1gAa/mmMvxgHFD0Zgj9GVY1EzzaGP3p57WU0dH5AzIMfefHgWd/hF TFVPgP1s0wXgV02+X57q321BOCzMf8dEgJsQY9GYw1rHg7Z4wDkNOI+d7kJrQUNh VY7w87hVDvskGKld+WAJeAQCPJBmFQky4zUVKCf7tz1nub8ylMgFVTJ09hCVFjsM /8i4q2kNRzjB9gH5plXZuT09w76Qg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehvddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D14843064AAE; Thu, 26 Nov 2020 10:41:30 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, Matan Azrad , Raslan Darawsheh , dpdk stable , Ori Kam , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ajit Khaparde Date: Thu, 26 Nov 2020 16:41:29 +0100 Message-ID: <3078378.W3qbV4VYx4@thomas> In-Reply-To: References: <20200811061443.8214-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/11/2020 15:42, Ajit Khaparde: > On Mon, Aug 10, 2020 at 11:15 PM Gregory Etelson wrote: > > > > According to current RTE API, port flow rules must not be kept > > after port stop. > > > > Testpmd did not flush port flow rules after `port stop' command was > > called. As the result, after the port was restarted, it showed bogus > > flow rules. > > > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Gregory Etelson > > Acked-by: Ori Kam > > Acked-by: Ajit Khaparde The rte_flow doc is now updated to make clear that flow rules are not kept after port stop. This testpmd patch should make clear that the need of flushing is only for testpmd objects. The change is postponed to DPDK 21.02.