From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 0B7E6B0C8
 for <dev@dpdk.org>; Thu, 12 Jun 2014 00:19:03 +0200 (CEST)
Received: by mail-wi0-f177.google.com with SMTP id r20so599547wiv.10
 for <dev@dpdk.org>; Wed, 11 Jun 2014 15:19:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=vYb59yXmDvk8EgsZWeKLKcXGS90EBctk/qbTBhaPfdY=;
 b=WGMkudgzo0SVSH/4H/Tv5TlLqfTau8MFZbY+hgAOKm5uXlYhJL9KU5PQ6wnr63UXMr
 QBgUgi24C87iqLBc9+OA1BZHxG1P9Lc7X/VLRcgvIST14uSfHgqpyOBeCW4bkswgg1zm
 4DlZy1vMmUlNhwIENaZ233zbEaX1hQgwMXA+7J8PiAr+TvtNPI6hVTu5HHED+8Ur/1P1
 WiKI+U+6o7vOZgLDKLg0I9TO8p3ZobEzfENK6feN1Ejf+p1e1dJVtEW5CEXxWekfMaZE
 UGp6BtgKfK9eCQitqsTKcUyut8PK1eiyZd46ObvmEY/bPGumDj2KG3DxfG6RAeASpHLH
 VTEA==
X-Gm-Message-State: ALoCoQmUt59W7k+kSI+EsdWSed+p3wnAqPvbk9a4jY7/ZY+e6Fhu4F3rzNhqKX4eefQwnNo7u841
X-Received: by 10.194.77.177 with SMTP id t17mr30502162wjw.55.1402525158922;
 Wed, 11 Jun 2014 15:19:18 -0700 (PDT)
Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr.
 [80.236.123.96])
 by mx.google.com with ESMTPSA id m3sm316593wik.7.2014.06.11.15.19.17
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 11 Jun 2014 15:19:18 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Thu, 12 Jun 2014 00:19:17 +0200
Message-ID: <3079600.trYA8PKFWl@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1399888587-21068-1-git-send-email-bruce.richardson@intel.com>
References: <1399888587-21068-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 22:19:04 -0000

Hi Bruce,

You are introducing a new option CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE.
I feel a comment in the code would be helpful here.

Sorry for not having checked before but there are some checkpatch issues
in this PMD.
Other simple cleanup: I think some include directives are useless.

Could you rework a new version please?

Thanks
-- 
Thomas