From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9704EA04FD; Mon, 4 Jul 2022 10:26:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83EFC410E5; Mon, 4 Jul 2022 10:26:51 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 1FEE340E09 for ; Mon, 4 Jul 2022 10:26:50 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C15B532007D7; Mon, 4 Jul 2022 04:26:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 04 Jul 2022 04:26:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656923205; x= 1657009605; bh=BzBycFZeQce1dX228F/lECV/ePj5XPfe5zzm2OI2C9U=; b=L auZWjPi4p6notylSAmjLs3dYcY/VxDjFIz9YhcRYRcW0bjBzHnc7bdR4/jwyZ9sN Ppnm0+lYImKCtY8BMLKbcYz9NW73PDxvh2wy5goPp7kVpklc4+8feU+KRrqkJIGr l8V57lARBgym5oFtc7bwDfDgP05JeYToLt/19Lmy6yA9npdRjmpVAkw1leu3cCmn r07kqHxYldjatg6GukFkfuqXKXS662f82Ttp+V7UilmgUnFIRtIN0jnepsz5V25s oZBqFL4JfkxN6sBNiKvw03MFbxkGZ9oSNjGnIjoC9RNr6rkY0DtqRUsjkMdhcqPc XxjpOLc2d4MBdvRR3EElA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656923205; x= 1657009605; bh=BzBycFZeQce1dX228F/lECV/ePj5XPfe5zzm2OI2C9U=; b=C 3hvV8Ej9pf0KaUf0jD5cmqeEogK/EmsPtWGNtShkx0PJq1uuyBMzHX3Snf06rp4g pi7CCbn8pHRPcYNI2DsvxV3pWE047cyWTwqzYP2u3F8Hth3oQaxofXnkPZWf5wo1 /nsLx34LKBqEvPG4ZMpYGPA10jZwfUW7AKIGvl2vb+87CHLp+Dcb/hOVq8EbJtVM UfMoe7vpOhuw79pfd6wsoOxj1Z9rFgx9j+VMFwBFHyFR/2n5y8SJQ/dNN2+E9I7Y P519J/MVRyK26pdx23T6bBXSWBet6NqcBoqHHybjW2zoD/qg4U9xPkWvQINZY0mX gZQ/AfNNfNqfyTAeESGXg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehledgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Jul 2022 04:26:43 -0400 (EDT) From: Thomas Monjalon To: Gowrishankar Muthukrishnan , Akhil Goyal Cc: David Marchand , dev , Fan Zhang , Brian Dooley , Anoob Joseph , Archana Muniganti , Jerin Jacob Kollanukkaran Subject: Re: [EXT] Re: [PATCH v2] examples/fips_validation: fix memory leak in sha test Date: Mon, 04 Jul 2022 10:26:40 +0200 Message-ID: <3081146.FMhQkTaH9n@thomas> In-Reply-To: References: <2acc661bc1b574166e599957c805d70eee0d3a42.1656773321.git.gmuthukrishn@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/07/2022 09:50, Akhil Goyal: > > On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan > > wrote: > > > > > > There is wrong size used for allocation of digest buffer which in > > > some cases cause memory corruption. Also, fixed places where memory > > > leak is observed. This fix would enable sha 384 and 512 NIST vectors > > > be supported fully. > > > > > > Fixes: 93d797d94f1 ("examples/fips_validation: add parsing for sha") > > > > This sha1 is not valid anymore, or maybe Akhil will squash the fix in > > the next-crypto tree before reaching main. > Fixed the SHA and applied on top of next-crypto as I had already asked Thomas to pull the tree. David did some good comments, I will wait for a better version of the patch.