From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B102E1B426 for ; Tue, 12 Feb 2019 12:15:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 366B9231CD; Tue, 12 Feb 2019 06:15:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 06:15:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4ZrEEsz8I4qVublKiedTWu4xKahKkWUCDpdP9tC4GjU=; b=LY7CfYVcqMSL QYa1a1mTrpqFNKGF48JKkJ6b9KP5WUhOWrOlaRnzFwLYnDnS/mj55/fd891vfs0l WPygDQiw3xOyEyUQvl+AF+g7daZscXajG0Rjtbr28AtmtOoSjiSszr+9Q+nnf6on TnVrLcoW6Y2GqmR9o0B5CYt31NR5B9s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4ZrEEsz8I4qVublKiedTWu4xKahKkWUCDpdP9tC4G jU=; b=etmBaCQPL2HLT3Fjwm7HCjjpbQTTrzVrdk6/fqQb3SVfSbH7T7q/I6SIV Zrc5we3JKs2DAXiFEuL1Ao3j5foqxnEKwzSbPw70mnkQRH8+IOG+DJWCgn8kz1Tp 7/8jOrJnYxIiGSTVXTlOzWv+uMXrY16SZV9PaiUZgvBooP2GLN3mdjwialLyLd5y Qo9kaiyKg7m0woeUs4pB2e2D0Gm/1DOAZpur0n4cprienbt7nNyxnqZN1RwxXaU5 kwdEdgeKA4EMzATX9HzXmW8qP0aMzkbAUsu9jArlEkDHhh0ovKdflXM9bbw8REVF weJnCp/iezzIpYc+gVxXnf71Nh3Cw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtuddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 093FE100E5; Tue, 12 Feb 2019 06:15:48 -0500 (EST) From: Thomas Monjalon To: Luca Boccassi Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Tue, 12 Feb 2019 12:15:43 +0100 Message-ID: <3082304.pESdSe8qVs@xps> In-Reply-To: <20190206170848.19059-2-bluca@debian.org> References: <20190103175725.5836-1-bluca@debian.org> <20190206170848.19059-1-bluca@debian.org> <20190206170848.19059-2-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 11:15:51 -0000 06/02/2019 18:08, Luca Boccassi: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for reverse dependencies of DPDK. Otherwise the recursive > dependencies are not parsed, and users doing static builds have to > resolve them manually by themselves. > When using this API avoid additional checks that are superfluous and > take extra time, and avoid adding the linker flag manually which causes > it to be duplicated. > > Signed-off-by: Luca Boccassi > Acked-by: Bruce Richardson This patch breaks compilation on my machine with a lot of strange errors: from drivers/net/pcap/rte_eth_pcap.c /usr/include/stdint.h:109: error: "__INT64_C" redefined /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' qualifier from pointer target type /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored etc