From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5CBC97F58 for <dev@dpdk.org>; Thu, 19 Apr 2018 16:45:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 07:45:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,469,1517904000"; d="scan'208";a="52041223" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2018 07:45:53 -0700 To: Arnon Warshavsky <arnon@qwilt.com> Cc: Thomas Monjalon <thomas@monjalon.net>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>, jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-8-git-send-email-arnon@qwilt.com> <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com> <CAKy9EB3MhL9RAkSZ-kQFLV5TgKNjSWd8BC1Su4LmPLNbfLi=4A@mail.gmail.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <3082a58f-46c9-d4c0-6c30-bb84a17bd6fe@intel.com> Date: Thu, 19 Apr 2018 15:45:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <CAKy9EB3MhL9RAkSZ-kQFLV5TgKNjSWd8BC1Su4LmPLNbfLi=4A@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 19 Apr 2018 14:45:56 -0000 On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: > Thanks Anatoly. Will fix that in v5. > Is it preferred to keep all version notes in the cover letter alone? > Generally, cover letter should give general outline (i.e. "fixed 32 bit compile"), while notes for individual patches should be more specific about the changes between versions (but not too specific, i.e. don't do "change variable X on line 100 to be Y"). So, whatever you think gets your point across best. Not all changes deserve to be called out in the cover letter. -- Thanks, Anatoly