From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED88EA0527; Mon, 9 Nov 2020 22:02:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C757C69C8; Mon, 9 Nov 2020 22:02:08 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 2C501697B for ; Mon, 9 Nov 2020 22:02:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id DB436CC7; Mon, 9 Nov 2020 16:02:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 09 Nov 2020 16:02:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= yOPlRUIqqUtSWQ3BK+l+vHrvtnGSqMlTqNYqXY+jhTI=; b=oh/ISEZAMwiDoyl9 GcdPzucjTzw8+DgCstGzaDV485uRBzijLDTRsoNddaZ32fWpMH1Z7BUa+Vd7SfUC mrZWyb0nwl/+ufOfnESwOJeEs+/0aVf362qRwE3JUtZkrYNYikxz5/hfdIiEywCg N1O2sGxKz5PYGmdI0Pfg58MlMq9F9Z6lAdQDS3lMbUawlilg+K3ZSDMBNG00LvxY I3KYWRr1S/pc6tFTkUn4odd3uvUfVFbaVdUKA/sCJgHGcq3uo+SRpc0KrGumlHSk REp1s0FRW56Hi0omjZDz366J6hC2dYmo/g6E1PZ45h8B40GSL6SjewdxMxyUEXFy 0EwXpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=yOPlRUIqqUtSWQ3BK+l+vHrvtnGSqMlTqNYqXY+jh TI=; b=isUQPH7Hsvd8Yay6qq1Sv4Duu2ij2u7gBT6OPAsKqsNatkWo29/2m/kVa 55QnVEzRMIJdLvWtKz7FB/gi2Q5VUYkAP1O2kyM5WtiWhWgxvt/LOOVDIKkxewbp KnluB83Ba3QmXyQk0evqmabf+F4t/fAQ0Mdqh6IV4v2o76ax4l0bV5T1CXuclzAa NjaF7z8VPRJR18k+pJYHna3ZaFBUqyFwYKe7lwZyZODlsUiWj/5yRb8wGKHz/ypu sRQ7uKhsaL4g3HeIZtYSUkkvt3+dFdlA1X+nZ9yPhYaGZhLXp0cRXbBvMbOadEvr S8iJ6f1u6CeZylhlPQ4ZrxxVVqYbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduhedgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B4C7328005A; Mon, 9 Nov 2020 16:02:03 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Bruce Richardson , david.marchand@redhat.com Date: Mon, 09 Nov 2020 22:02:01 +0100 Message-ID: <3084224.aG0oiDBsVl@thomas> In-Reply-To: <2240726.PXfc15pV6C@thomas> References: <20201109130035.3948462-1-ferruh.yigit@intel.com> <3526179.Ta2yc0qjKd@thomas> <2240726.PXfc15pV6C@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2020 18:44, Thomas Monjalon: > 09/11/2020 18:20, Thomas Monjalon: > > 09/11/2020 18:15, Ferruh Yigit: > > > On 11/9/2020 5:01 PM, Thomas Monjalon wrote: > > > > 09/11/2020 17:48, Ferruh Yigit: > > > >> I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH', > > > >> what is the intention/plan with the config file? > > > > > > > > You should use a config file to set PKG_CONFIG_PATH, PATH, > > > > DPDK_MESON_OPTIONS, etc accordingly to build with all > > > > your non-installed dependencies. > > > > CUSTOM_PKG_CONFIG_PATH is a way to avoid using the config file > > > > in a single case. > > > > > > > > > > Either use 'PKG_CONFIG_PATH' environment variable or a config file, both has the > > > same problem that we need two different pkg config path, one for 64bit and one > > > for 32bit. > > > > No. In the config file, you can set the right value by testing $DPDK_TARGET. > > Note: the config file is a shell script. > > > > > v2 of this patch provides a way to use correct one when needed. > > > > This is not a global fix. > > > > > Moving the default values from system environment or script hardcoded values to > > > a config file is something else and can be done later, what do you think? > > > > The root cause of your issue is using variables from the environment. > > The global fix is then to reset them all, > > while keeping a default value for PATH which is not only for compilation config. > > This is what we have currently: > > export PATH=$default_path > export PKG_CONFIG_PATH=$default_pkgpath > export CPPFLAGS=$default_cppflags > export CFLAGS=$default_cflags > export LDFLAGS=$default_ldflags > unset DPDK_MESON_OPTIONS > > The PATH needs to be restored at each run to avoid using a wrong toolchain. > The default value is best taken from the start environment, > at the condition no conflicting toolchain is already set. > > PKG_CONFIG_PATH is specific to each target. > I believe it can be reset at each run and configured > only from the config file. > A default PKG_CONFIG_PATH for all targets does not make any sense. > > CPPFLAGS, CFLAGS and LDFLAGS could be used to customize some options > applying to all targets in some build tests without touching the config file. > > DPDK_MESON_OPTIONS could be the same as CFLAGS: take a global default from env > and restore the value at each run, so each target can have additional options > from the config file. The implementation of the above is done in this patch: https://patches.dpdk.org/patch/83861/