From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 20C7A6A95
 for <dev@dpdk.org>; Thu, 11 Dec 2014 01:37:23 +0100 (CET)
Received: by mail-wg0-f52.google.com with SMTP id x12so5064514wgg.39
 for <dev@dpdk.org>; Wed, 10 Dec 2014 16:37:22 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=egEDZRAgfZLwpJ9EqUcT2a9gTUuU1Oa5PugnMtEruTg=;
 b=ELW7q39BVGt980SZ9pq9mB1IASnbj0puC7NNzMiLQEjV8IQYJ5uI4ewi1SRlpQLVF2
 GwjPrbI1d8CPOdURj7Ui6llvUrtU+/Asiy9hm250w9F/BWv9wHqnM8foCbUcsgEzVZtV
 xKmTiADFbfU2wpm5nyNxocWFeejMLhpOSkHXEWaZPS2sPQmN+bLcfR4LKylnoou9MV+T
 K6bv2fnx3wgCZy20gl+twAFMqzHy8Xj1UzLPzfGChPOwQ0g06Ae7aPgv/0+KY7g4y06q
 b/onpCfWHg+hkWKv+p7We7l5rK2HkUc0nq9OhTNM+JRTdE835TBhVQJ8mRBiFE4vjiyE
 WUmQ==
X-Gm-Message-State: ALoCoQkjwF9wapVmAxcobIgx5MHZ+JXUT6BhldzMXooUG4VJlhgt7WgESb3hHs6eMDJPagruLzhP
X-Received: by 10.194.189.240 with SMTP id gl16mr10903077wjc.119.1418258242661; 
 Wed, 10 Dec 2014 16:37:22 -0800 (PST)
Received: from xps13.localnet ([88.249.222.12])
 by mx.google.com with ESMTPSA id ex9sm730665wib.14.2014.12.10.16.37.21
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 10 Dec 2014 16:37:21 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 11 Dec 2014 01:36:54 +0100
Message-ID: <30845403.kPBAiWVWY3@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <20141211002838.GA24240@localhost.localdomain>
References: <1415381289-43291-1-git-send-email-jyu@vmware.com>
 <D0ADD64A.2E3F8%jyu@vmware.com>
 <20141211002838.GA24240@localhost.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Dec 2014 00:37:23 -0000

Hi Neil,

2014-12-10 19:28, Neil Horman:
> On Wed, Dec 10, 2014 at 07:09:03PM +0000, Jia Yu wrote:
> > Hi Neil,
> >=20
> > Moving __rte_cache_aligned right after struct keyword will help. On=
 the
> > other hand, enforcing this rule for existing (100+) and future defi=
nitions
> > will be difficult. It=B9s clearer and a good practice to include he=
ader file
> > explicitly.
> >=20
> You need to include the header file regardless of what you do.  The a=
dvantage to
> placing the macro right after the struct keyword is that failure to i=
nclude the
> header will result in a compiler error, rather than silent behavioral=
 changes
> and run time breakage.
>=20
> You don't have to enforce putting the attribute after the struct keyw=
ord, I'd
> say just move them now to protect the current code.  Subsequent patch=
 authors
> will see the existing style and follow suit.  Or they won't, and we'l=
l point out
> the issue during review.

It should be a different patch for next release cycle.
Let's apply this fix only for 1.8.0.

--=20
Thomas