From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 81C211BDD8 for ; Wed, 27 Jun 2018 16:09:09 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6CC1401DE60; Wed, 27 Jun 2018 14:09:08 +0000 (UTC) Received: from [10.36.112.39] (ovpn-112-39.ams2.redhat.com [10.36.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E2A11C67B; Wed, 27 Jun 2018 14:09:04 +0000 (UTC) To: Shahaf Shuler , Ferruh Yigit , "bernard.iremonger@intel.com" , "dev@dpdk.org" Cc: "ailan@redhat.com" , "jan.scheurich@ericsson.com" , "vkaplans@redhat.com" , "bruce.richardson@intel.com" , Thomas Monjalon , "konstantin.ananyev@intel.com" , Jens Freimann References: <20180623080840.315-1-maxime.coquelin@redhat.com> <20180623080840.315-2-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <308c794e-7aea-c848-5b4c-afeb825c9d21@redhat.com> Date: Wed, 27 Jun 2018 16:09:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 27 Jun 2018 14:09:08 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 27 Jun 2018 14:09:08 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 14:09:09 -0000 Hi Sharaf, On 06/27/2018 03:51 PM, Shahaf Shuler wrote: > Tuesday, June 26, 2018 4:39 PM, Ferruh Yigit: >> Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to >> simulate a noisy neighbour >> >> On 6/26/2018 1:17 PM, Shahaf Shuler wrote: >>> HI Maxime, Jens >>> >>> Saturday, June 23, 2018 11:09 AM, Maxime Coquelin: >>>> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to >>>> simulate a noisy neighbour >>>> >>>> From: Jens Freimann >>>> >>>> This adds a new forwarding mode to testpmd to simulate more realistic >>>> behavior of a guest machine engaged in receiving and sending packets >>>> performing Virtual Network Function (VNF). >>> >>> I really like the idea of adding application w/ more realistic behavior to the >> DPDK tree in order to use them in the non-regression cycle. >>> >>> I am just wondering if putting it as another forward engine in testpmd is >> the right place for it. >> >> Hi Shahaf, >> >> This was the request in old review comments. As you said it is good to have >> more realistic behavior but also we would like to test/use io forwarding, so >> new forwarding engine is way of having both two. > > Sorry, I missed reading the previous comments. > As I said, there are upsides and downsides to it. I still think it deserve a separate example but we can start inside testpmd and move it to other location when needed. I get your point, but I think it is better to have it in testpmd as we intend to use it to gather some benchmarks. And yes, if this is turn out to be problematic, we can move it outside testpmd at some points. Thanks for your insights, Maxime