From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id E42F05938 for ; Mon, 5 Jan 2015 21:38:50 +0100 (CET) Received: by mail-wg0-f53.google.com with SMTP id x13so10478391wgg.12 for ; Mon, 05 Jan 2015 12:38:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vfFJzQVriXunGiQ0fJfkN68gSwd21gIrZLpIpugQdXI=; b=UXKVdHRcPSoyFdAlmOmLZK56/PO4g8IIWGuZM38xVHGALy9xZnE3sBIefh/G5i1S3l FrwwDpQNraG/0PpRacxvvBoQET5MuK+z2IQBfYvu3NkwcJN/hFgb+Nl3BbmMbAzjd8Kw JrH7Dq7WtIzmomow+jhpHGwH5P50VXSzR7hOKxwCbTmxP7CO/M3UexDA0V3WrH5CerUR qUnP3l4J2Fhx2ewMFETMA0MbajQ5+vLxV8meGxzTASzIITmbpdQidlEoH2WHIrXl2453 yHjGBa6sBgoPb6bGgU2qE6PfS2L3L2pyIwJcZRkboDk6nuYUw04oZeqhfDci8Zx8zKPx kfiQ== X-Gm-Message-State: ALoCoQmD286UhMnqM2SA87Kr+lOuO75Ehhcl4rz0wp+pYNd4db/r3iyMd06esiw8q2BaSbAvYUuA X-Received: by 10.194.5.37 with SMTP id p5mr62665759wjp.20.1420490330609; Mon, 05 Jan 2015 12:38:50 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id p14sm11300311wie.1.2015.01.05.12.38.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 12:38:49 -0800 (PST) From: Thomas Monjalon To: Ravi Kerur Date: Mon, 05 Jan 2015 21:38:27 +0100 Message-ID: <3095360.cfZ4UIMKPn@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <20293089.lIc3yRvdMZ@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 20:38:51 -0000 2015-01-05 10:56, Ravi Kerur: > On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon > wrote: > > 2014-12-25 10:33, Ravi Kerur: > > > Move common functions in eal.c to librte_eal/common directory. > > [...] > > > lib/librte_eal/common/eal_common.c | 328 ++++++++++++++++++++++++++++++++++ > > > lib/librte_eal/common/eal_externs.h | 42 +++++ > > > > I don't agree with these new files. > > We must try to keep a semantic organization. The file eal_common_options.c > > would be better for option-related functions. > > Maybe that the split between system config, runtime config and internal > > config > > must be reworked. > > > > By the way, it would be nice to avoid extern variables. > > I have taken care of your comments and will generate v4 patch. Please do not forget v4 word and changelog when sending patches. Check http://dpdk.org/dev#send > Currently I have moved common functions in eal.c into > "eal_common_system_options.c" file. Are you suggesting that we further > divide "eal_common_options.c" and "eal_common_system_options.c(new file > added)" into 3 separate files i.e. > > eal_common_system_options.c > eal_common_runtime_options.c > eal_common_internal_options.c You are already doing big changes. So let's iterate with existing files and avoid creating new ones. eal_common_options.c must be kept. But if some code is not really related to runtime options, we could consider adding a new file eal_common_config.c, not sure about this one. -- Thomas