From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34287A0542; Wed, 5 Oct 2022 11:06:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2864840A7D; Wed, 5 Oct 2022 11:06:21 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B65B340694 for ; Wed, 5 Oct 2022 11:06:19 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6F8D05C00CC; Wed, 5 Oct 2022 05:06:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 05 Oct 2022 05:06:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664960779; x= 1665047179; bh=hWWLhkzCjmvcRIny+icxIhZpai1+48cpA995o52zUEo=; b=f 1qndmIsFKvWg71fTAK24Z6yRJPV5cwyKDkume19TU/ttK018On5q8lu75iTv4qRX jiIejfI5MIFvM4/bXtJftt3GfyKksO/Naz1aoZEvik7+vx7bSRAIsakapjlp6aNS YBVbiIybwVOCtJQIuA/JerWDAi4Pr2QX40TIpy8sogc1xgk7GFi4aL22K8e5qD/e QNo6s3g8kix6gvO0rdRQGmHlTHBPGJqypRcQZr8e3XyVqFBVY7iAZ6E1PCrXoyr5 Kjhjr9iKjfu5QyF4M8FK73HPxEUhpzH2sW70LfsR5XX8HD5N2GT43JQzRBFCTshE qfacPebBUkzbzB0KZ4qgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664960779; x= 1665047179; bh=hWWLhkzCjmvcRIny+icxIhZpai1+48cpA995o52zUEo=; b=v AMkrOe02W38JR3ptd4ZbcJTaiKdbD3eG1pcEcMd7P4GIhzK4vrNHlEN0Enhwy3yU IRrWEWC745D6J2EPmna8YIB3o6cbwEcIaL36D1tmKUbDWaxgI6JBd3lIaQWGnrzh mXw0ExgNXtGC35E0XpxvGpQ6hbI9N2FkzuqsPItL3tCqgSoDSU7UWblS59I3SEeC dE0d8Dc5uLbNs5842Pd/c6756JpIvPwAl50cKjacUF5MUbsVhtWagbOtLYHpW8JJ CtJMJZJCdMOLdu2RFa3jb+FKcaobhMl26s/L4UCdszHc5ACa71S36KGBxh99P3SB 4YTElszjNPT1hJ+M0m0ew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtuf ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeejffffgfffkeefff elgfekleetjeffleeludeghfehleffteehveduffdugfdvnecuffhomhgrihhnpeguphgu khdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Oct 2022 05:06:18 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff , Tyler Retzlaff Cc: dev@dpdk.org, anatoly.burakov@intel.com, ranjit.menon@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, david.marchand@redhat.com Subject: Re: [PATCH 1/3] doc: announce cleanup of rte_{bsf, fls} inline functions type use Date: Wed, 05 Oct 2022 11:06:15 +0200 Message-ID: <3096049.D8ZAKjAxdT@thomas> In-Reply-To: <1659993692-17479-2-git-send-email-roretzla@linux.microsoft.com> References: <1615418650-19513-1-git-send-email-roretzla@linux.microsoft.com> <1659993692-17479-1-git-send-email-roretzla@linux.microsoft.com> <1659993692-17479-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/08/2022 23:21, Tyler Retzlaff: > From: Tyler Retzlaff > > The cleanup resulted from request to review [1] the following > functions where there appeared to be inconsistency in return type > or parameter type selections for the following inline functions. > > rte_bsf32() > rte_bsf32_safe() > rte_bsf64() > rte_bsf64_safe() Why _safe functions are not changed? > rte_fls_u32() > rte_fls_u64() > rte_log2_u32() > rte_log2_u64() > > [1] http://mails.dpdk.org/archives/dev/2021-March/201590.html > > Signed-off-by: Tyler Retzlaff > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index e7583ca..58f4c24 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > +* eal: Fix inline function return and parameter types for rte_{bsf,fls} > + inline functions to be consistent in DPDK 22.11. > + Change ``rte_bsf64`` return type to ``uint32_t`` instead of ``int``. > + Change ``rte_fls_u32`` return type to ``uint32_t`` instead of ``int``. > + Change ``rte_fls_u64`` return type to ``uint32_t`` instead of ``int``. It is too late for the announce, but the release notes requires to be updated.