From: Thomas Monjalon <thomas@monjalon.net>
To: luca.boccassi@gmail.com
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
John Alexander <John.Alexander@datapath.co.uk>,
Luca Boccassi <luca.boccassi@microsoft.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [kmods PATCH v2] windows: normalize line-endings
Date: Fri, 13 Nov 2020 00:17:45 +0100 [thread overview]
Message-ID: <3097625.jnL5zvyN3p@thomas> (raw)
In-Reply-To: <20201112201509.1002479-1-luca.boccassi@gmail.com>
12/11/2020 21:15, luca.boccassi@gmail.com:
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> MSBuild XML files have to use CRLF line-endings, otherwise any change
> results in the whole file being rewritten with CRLF line-endings by
> Visual Studio. However, it's inconvenient to have such files checked-out
> with CLRF in Unix environments.
>
> Add suggested git configuration to top-level README, so that Unix
> developers don't miss it. Remove .gitattributes, because core.autocrlf
> overrides eol= attribute. Convert line-endings of the existing files in
> the repository.
>
> Suggested-by: John Alexander <John.Alexander@datapath.co.uk>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2 from Luca: run dos2unix on all files in windows/virt2phys folder
[...]
> +Some Windows files use have to use CRLF line-endings.
> +Unix developers can configure git to get only LF on checkout:
> +
> + git config core.autocrlf input
This is the same as in v1:
- same typo "use have to use"
- this config is probably useless
next prev parent reply other threads:[~2020-11-12 23:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 22:55 [dpdk-dev] [kmods PATCH] " Dmitry Kozlyuk
2020-11-03 4:05 ` Narcisa Ana Maria Vasile
2020-11-03 7:42 ` Dmitry Kozlyuk
2020-11-03 10:05 ` Luca Boccassi
2020-11-11 15:02 ` Luca Boccassi
2020-11-11 15:11 ` Dmitry Kozlyuk
2020-11-03 20:49 ` Narcisa Ana Maria Vasile
2020-11-11 15:02 ` Thomas Monjalon
2020-11-11 15:03 ` Luca Boccassi
2020-11-11 15:09 ` Luca Boccassi
2020-11-12 20:16 ` Luca Boccassi
2020-11-12 20:15 ` [dpdk-dev] [kmods PATCH v2] " luca.boccassi
2020-11-12 23:17 ` Thomas Monjalon [this message]
2020-11-13 7:06 ` Dmitry Kozlyuk
2020-11-13 9:43 ` Thomas Monjalon
2020-11-13 9:52 ` Luca Boccassi
2020-11-13 9:50 ` [dpdk-dev] [kmods PATCH v3 1/2] windows: remove .gitattributes luca.boccassi
2020-11-13 9:50 ` [dpdk-dev] [kmods PATCH v3 2/2] windows: normalize line-endings luca.boccassi
2020-11-13 15:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3097625.jnL5zvyN3p@thomas \
--to=thomas@monjalon.net \
--cc=John.Alexander@datapath.co.uk \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=luca.boccassi@gmail.com \
--cc=luca.boccassi@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).