From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DFBDA04E7; Sun, 1 Nov 2020 19:11:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8601D3253; Sun, 1 Nov 2020 19:08:46 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7762D2D41 for <dev@dpdk.org>; Sun, 1 Nov 2020 19:08:44 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2B0E95C00AD; Sun, 1 Nov 2020 13:08:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 01 Nov 2020 13:08:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= F4QJi918OUAr1wbht+/UwioaDWtMt+tWu+AGlR1jRmg=; b=GTPuH9kw4Vbd/ouG QbJyRWmt9jHgveIB2Z+Ptba/QV0afkEOvdZqVj9YjCy+5wmq2QeXFZwsYxtElTco eGTg2G+7B3qj5DlFYghDq/yBygz2W9ZFipyNnBk3gn9EL/qD1Zqla+vet1jhmT3n QGFlDxMELIJaVjRbASeNj3ZbtvHbUJ9wGrIcQ6AZiulhWKUF7fX/9kZN83g/GHeV cjwRS++4Y+rnDFDv3y89gFrpHt2qcTUzuDw6KZjeR16L98WkwFvfsc4sMKrsaV8D 4phxYbODI3lFAwcUmnUgdtz2YEimnWZxgAWgpI6eCeimW8kJAHPqS8uPFunWyFJM r8ajuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=F4QJi918OUAr1wbht+/UwioaDWtMt+tWu+AGlR1jR mg=; b=Ej+akvTpnRRTKT2xXmPF2lOWn4n+d1GLrdM+s/ilixpzDKymMWNaoXFUU 966jE+znCgTXoIa9Ijkg7Ox3Xbklxt63Tbc9n8e4wt+xpsoCVJii7BB/zHVFO4EF nCDhBQUTBp9ASXW6oceraVGs01FDDC+5hvJUrlw5A9FV1nzPmt5nkQpM7D2vm62J jNPPn62UM7lvHBMcSb7Rmz+52w5XxsZ4AbznyC8ksO8e99XDi6fEOx0hcPcQUVlG 73mAF1rQtgA8CgQD4xeH57dc80OtDiIyWD9IRq8bpQVIztzHfYvxm+UBSblfb5q6 kJAfkOtch/dBlNQM6TKZl1II9MOyg== X-ME-Sender: <xms:qvmeXzKIcclan5Xj_IDmP8xB2jMGZj1eZJV90Wy-W15cXXUzLeT8Nw> <xme:qvmeX3IFwvcbKGUEeqxj9C8kXYokrHcyCPv9w1LToCgxtUhhY0Hs8YH7tPn4Div25 7Y_pDIP0VpvD9fYjA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleelgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:qvmeX7sV-aZCx5ULuvSW3J1yPOI91vohyLR8JqiTI8LHFybMgwc3Lg> <xmx:qvmeX8au21j7KG16M771ozdaYZxzvgJUOO0zz-qH3gmFqSJKLYr3yQ> <xmx:qvmeX6YSW0MCFIsRPcXwYFXiZWJK5lmQQalW28K38xTeInJmFFyVcg> <xmx:q_meXxzF9ASST2Hoc8HiK0aCjPXtcdm6-dUpX1IULZUQwchelC90Cw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A1B4B3064674; Sun, 1 Nov 2020 13:08:41 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com Date: Sun, 01 Nov 2020 19:08:40 +0100 Message-ID: <3098149.fGbqAXrStZ@thomas> In-Reply-To: <20201101180626.2198868-1-thomas@monjalon.net> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201101180626.2198868-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 00/14] remove mbuf timestamp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 01/11/2020 19:06, Thomas Monjalon: > The mbuf field timestamp was announced to be removed for three reasons: > - a dynamic field already exist, used for Tx only > - this field always used 8 bytes even if unneeded > - this field is in the first half (cacheline) of mbuf > > After this series, the dynamic field timestamp is used for both Rx and Tx > with separate dynamic flags to distinguish when the value is meaningful > without resetting the field during forwarding. > > As a consequence, 8 bytes can be re-allocated to dynamic fields > in the first half of mbuf structure. > It is still open to change more the mbuf layout. > > This mbuf layout change is important to allow adding more features > (consuming more dynamic fields) during the next year, > and can allow performance improvements with new usages in the first half. The changelog was missing: v2: - remove optimization to register only once in ethdev - fix error message in latencystats - convert rxtx_callbacks macro to inline function - increase dynamic fields space - do not move pool field