From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 873CD3B5 for ; Fri, 17 Feb 2017 17:01:06 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 17 Feb 2017 08:01:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="65952075" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by orsmga005.jf.intel.com with ESMTP; 17 Feb 2017 08:01:04 -0800 To: Wei Zhao , dev@dpdk.org References: <1486971319-59788-1-git-send-email-wei.zhao1@intel.com> Cc: Wenzhuo Lu From: Ferruh Yigit Message-ID: <30c77873-18e6-9d2e-65d2-201c534ec554@intel.com> Date: Fri, 17 Feb 2017 16:01:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1486971319-59788-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 16:01:06 -0000 On 2/13/2017 7:35 AM, Wei Zhao wrote: > All kinds of filter need to hardware mac type check > to make sure the hardware support that type of fliter. > If not, it may cause serious issue. > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter") > Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter") > Fixes: 429f6ebb42cc ("net/ixgbe: parse TCP SYN filter") > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ixgbe/ixgbe_flow.c | 129 +++++++++++++++++++++-------------------- > 1 file changed, 65 insertions(+), 64 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c > index 5a634d3..f414fa8 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -84,11 +84,12 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, > struct rte_eth_ntuple_filter *filter, > struct rte_flow_error *error); > static int > -ixgbe_parse_ntuple_filter(const struct rte_flow_attr *attr, > - const struct rte_flow_item pattern[], > - const struct rte_flow_action actions[], > - struct rte_eth_ntuple_filter *filter, > - struct rte_flow_error *error); > +ixgbe_parse_ntuple_filter(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct rte_eth_ntuple_filter *filter, > + struct rte_flow_error *error); Hi Wei, You don't need these function declarations at all. What do you think removing these first, in a separate patch, and won't need to update them here? Also it is possible to remove all function declarations if you move "ixgbe_flow_ops" at the end of the file, that would be something I prefer, but it is your call. Thanks, ferruh