From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD308A0A0A; Fri, 22 Jan 2021 14:53:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC209140FEB; Fri, 22 Jan 2021 14:53:35 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 78CE7140FDF; Fri, 22 Jan 2021 14:53:34 +0100 (CET) IronPort-SDR: tcRNhXSMq7vvIBdwKlEdSFWEzf6G8EPephsefR1MrSSZYkmpJWrOt94SM+mgXmw8xpdxvHLge3 CPd3NlOmUQFw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="240988120" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="240988120" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:53:33 -0800 IronPort-SDR: +jE2zxVWR7N5sg1YNBK6CelCOyFPRzgTk9wbhv3SEb5cALiLIOksUJw+cq84w4uxJXimnRaV7/ HpjylBZqSJSw== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="357034282" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.25.114]) ([10.213.25.114]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:53:31 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson References: <20210120135556.33763-2-david.hunt@intel.com> <20210121172201.22582-1-david.hunt@intel.com> <20210121172201.22582-7-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: <30c98203-4caf-e927-2ee0-f8cf9eb2b33b@intel.com> Date: Fri, 22 Jan 2021 13:53:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210121172201.22582-7-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 6/6] power: clean up includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21-Jan-21 5:22 PM, David Hunt wrote: > From: Bruce Richardson > > re-organise the including of the new public header file and > remove un-needed includes > > Fixes: 210c383e247b ("power: packet format for vm power management") > Fixes: cd0d5547e873 ("power: vm communication channels in guest") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > Signed-off-by: David Hunt > --- > examples/vm_power_manager/channel_manager.c | 1 - > examples/vm_power_manager/channel_monitor.c | 1 - > examples/vm_power_manager/channel_monitor.h | 2 +- > examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 1 - > examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 -- > examples/vm_power_manager/vm_power_cli.c | 1 - > lib/librte_power/guest_channel.c | 2 +- > lib/librte_power/guest_channel.h | 2 -- > lib/librte_power/power_kvm_vm.c | 2 +- > lib/librte_power/rte_power.h | 1 + > lib/librte_power/rte_power_guest_channel.h | 3 --- > 11 files changed, 4 insertions(+), 14 deletions(-) > > diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c > index c7d5bf5a8..0a28cb643 100644 > --- a/examples/vm_power_manager/channel_manager.c > +++ b/examples/vm_power_manager/channel_manager.c > @@ -27,7 +27,6 @@ > #include > > #include "channel_manager.h" > -#include "rte_power_guest_channel.h" > #include "channel_monitor.h" > #include "power_manager.h" > > diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c > index 7bb33e026..99f81544d 100644 > --- a/examples/vm_power_manager/channel_monitor.c > +++ b/examples/vm_power_manager/channel_monitor.c > @@ -35,7 +35,6 @@ > > #include > #include "channel_monitor.h" > -#include "rte_power_guest_channel.h" > #include "channel_manager.h" > #include "power_manager.h" > #include "oob_monitor.h" > diff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h > index 5d3537b91..9184a8327 100644 > --- a/examples/vm_power_manager/channel_monitor.h > +++ b/examples/vm_power_manager/channel_monitor.h > @@ -5,8 +5,8 @@ > #ifndef CHANNEL_MONITOR_H_ > #define CHANNEL_MONITOR_H_ > > +#include > #include "channel_manager.h" Should have newline before quoted headers, e.g. #include #include "blah" Otherwise, Acked-by: Anatoly Burakov -- Thanks, Anatoly