From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 77D4C4C74 for ; Wed, 27 Feb 2019 11:50:25 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id e74so5298871wmg.3 for ; Wed, 27 Feb 2019 02:50:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xWYFsPjq218pAt2afIThd5ikD1i0swUTGv28fXemqtQ=; b=uiSX1R1ON2WsfwW0PbbLbT6TLHXaSJMPoR0TmVt4iPKZUvUPxpguhCMScJvem1nq+Y Tbeg/4f5zGrsxNW29Gnc0xkjBSKElnXQBwTzgrM99VQ8M1jQHTVVBjU+bCaGvK6B3hIm /ub3uqgeTTAUBY54JBN4Rxp7WAh6M/tIZCIZapcu7ISceMZmVf/0yuzMN7IcjfE1AmkR zJ9/o/bkkj8/11OS86AugQrtIfkqM6hyEY0Z2cbsjrOJ1fnSXPeLz+gAe2+iJbHP7jc3 UcmlJtHbPCOvmDTHWpwxZ6JI4SDw0yfBF/vs9vYie9D9E2owQ0QcRTwc02RLJtoX1saA aQsA== X-Gm-Message-State: AHQUAubClPVRYjWiLXRSpp8DRn2WVxVoTKrsKztBbK8EZeVDBL2MpJi2 YygjulSZ8cmr61fUcOa4MxA= X-Google-Smtp-Source: AHgI3Ia08RCi+JYfr/8z7OoL3jBBbYcNAODNUzxeoYfXGlNYI6tw1FUwdjyHUY+GLcfb79HFDg7vCQ== X-Received: by 2002:a1c:a756:: with SMTP id q83mr1835107wme.8.1551264624748; Wed, 27 Feb 2019 02:50:24 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id m15sm10934164wrx.30.2019.02.27.02.50.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 02:50:23 -0800 (PST) Message-ID: <30cb42a8b2e0f0de063bc783fef8e4a4d86dbc52.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , Thomas Monjalon Cc: dev@dpdk.org Date: Wed, 27 Feb 2019 10:50:21 +0000 In-Reply-To: <20190227094746.GA91912@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190226174637.27452-6-luca.boccassi@gmail.com> <2422048.eyOlUYzsqs@xps> <20190227094746.GA91912@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 10:50:25 -0000 On Wed, 2019-02-27 at 09:47 +0000, Bruce Richardson wrote: > On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > > 26/02/2019 18:49, Luca Boccassi: > > > On Tue, 2019-02-26 at 17:46 +0000, luca.boccassi@gmail.com wrote: > > > > From: Luca Boccassi > > > >=20 > > > > pcap has historically shipped a custom pcap-config binary tool > > > > which > > > > does the job of pkg-config. It was never compatible with cross > > > > compilation. > > > > Meson uses it when using dependency(), which then means cross > > > > compilation fails. > > > > Set pcap-config to empty in the meson cross compilation files > > > > so > > > > that Meson will not use it, and add a fallback in case > > > > dependency() fails. > > > > libpcap 1.9.0 finally ships a pkg-config file so everything > > > > will > > > > work out of the box in the future. > > > >=20 > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > v8: added back pcap change separately. Tested with bootlin > > > > cross-compilation toolchain, everything seems to work. > > >=20 > > > I had some time to invest so I added back this change, in a way > > > that > > > works with cross compilation too. Given the series wasn't merged > > > yet > > > and there was a conflict I've done a v8 rather than a single > > > separate > > > patch, but it's independent from the rest. > > >=20 > > > More testing is of course welcome! > >=20 > > I still see the same error when cross-compiling: > >=20 > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > >=20 > Can patches 1-5 be merged anyway, leaving 6 for later? >=20 > /Bruce Yes please... Thomas, could you please give me detailed instructions on how to repro? I used the bootlin toolchain you linked me last time, and passed -- cross-file config/arm/arm64_armv8_linuxapp_gcc to Meson, and everything built fine both with and without an arm64 build of libpcap in the sysroot. With the previous version that I removed it would fail. Not sure what I'm missing! --=20 Kind regards, Luca Boccassi