DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ian Stokes <ian.stokes@intel.com>, dev@dpdk.org
Cc: stephen@networkplumber.org, arybchenko@solarflare.com,
	Qi Zhang <qi.z.zhang@intel.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Alejandro Lucero <alejandro.lucero@netronome.com>,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] doc: announce ethdev ABI change for rte_eth_dev_info.
Date: Thu, 22 Nov 2018 18:27:35 +0000	[thread overview]
Message-ID: <30f1a1d5-e38e-c933-e0d0-9800b2470706@intel.com> (raw)
In-Reply-To: <1542888549-24656-1-git-send-email-ian.stokes@intel.com>

On 11/22/2018 12:09 PM, Ian Stokes wrote:
> Maximum and minimum MTU values vary between hardware devices. In
> hardware agnostic DPDK applications access to such information would
> allow a more accurate way of validating and setting supported MTU values on
> a per device basis rather than using a defined default for all devices.
> 
> The following solution was proposed:
> 
> http://mails.dpdk.org/archives/dev/2018-September/110959.html
> 
> This patch adds a depreciation notice for ``rte_eth_dev_info`` as new
> members will be added to represent min and max MTU values. These can be
> added to fit a hole in the existing structure for amd64 but not for 32 bit,
> as such ABI change will occur as size of the structure will be impacted.
> 
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 34b28234c..da2b1ce15 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -49,6 +49,18 @@ Deprecation Notices
>    Target release for removal of the legacy API will be defined once most
>    PMDs have switched to rte_flow.
>  
> +* ethdev: Maximum and minimum MTU values vary between hardware devices. In
> +  hardware agnostic DPDK applications access to such information would allow
> +  a more accurate way of validating and setting supported MTU values on a per
> +  device basis rather than using a defined default for all devices. To
> +  resolve this, the following members will be added to ``rte_eth_dev_info``.
> +  Note: these can be added to fit a hole in the existing structure for amd64
> +  but not for 32 bit, as such ABI change will occur as size of the structure
> +  will increase.
> +
> +  - Member ``uint16_t min_mtu`` the minimum MTU allowed.
> +  - Member ``uint16_t max_mtu`` the maximum MTU allowed.
> +
>  * pdump: As we changed to use generic IPC, some changes in APIs and structure
>    are expected in subsequent release.
>  
> 

cc'ed a few more folks.

  parent reply	other threads:[~2018-11-22 18:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 12:09 Ian Stokes
2018-11-22 12:11 ` Ferruh Yigit
2018-11-22 17:15   ` Thomas Monjalon
2018-11-24 17:37     ` Thomas Monjalon
2018-11-22 18:27 ` Ferruh Yigit [this message]
2018-11-23  8:08   ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30f1a1d5-e38e-c933-e0d0-9800b2470706@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ian.stokes@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=shahafs@mellanox.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).