From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 134AA10D69 for ; Thu, 22 Dec 2016 14:10:28 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id g23so175348290wme.1 for ; Thu, 22 Dec 2016 05:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=7GuD/1eJIBx/RlwjZHVpy8PtFMy+j8ayj6lcKfQeqes=; b=aMtp4VjuDUQnGTOiftp0bGoBoCcq99dwaQZyl5AfZZvLqBd5/L81q5ESkrZFx7HX3l N5oZm3w0ao7y+MROGqwK+8Z2sYJi61vesKmFAZBm6F2wUkD5TdkyXLlsuHjQQjpV6HVV nbJbi6lOFtwhassUvWlX6wkxlLJMAUtYyEEuFn2rFQPngalS9KKJ2dHIrni+Z26AyXPg RP3vs6j8eaq0g1dnVBn5RaLRqdpOxzu2XmwuDUF7I2nK+N9adom8cvVGCiXy5Ot2Ie6P SDDDijziqSL4kxZRg8NzEZmJ9J+IcF7wjxCrIfz6QK/qJECowAkmoLiw0y3TJjxCEJ+h UtrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=7GuD/1eJIBx/RlwjZHVpy8PtFMy+j8ayj6lcKfQeqes=; b=H9RCEQDlmF0hHCYYLcnQ+e7qPuj4JuIopRaDJl/wxm8RhCCdhlaoVKdzhs5ti1vdlA oAbUChvpGwoFVEWFMiU+BQvLQWkwIBHArkHoXzP7FjqWMoSp7rFfSeIkiQ0EjPXT6h5w Gxi9yk2lB5N8MoGpSgd2xfthZ9LbS7U3dUYuyhaSGCXp1kqb10vjddPf9tQk+UjCuB+q TADOTNvNIALWzYUCZRfJa5dEbDT1V+Kx/fiC1xeD/elaRqFX0VYgjHs5buwTRP9SNVny kCjCfNjiselIzBIo9SC6ypMGz8PAoXV85RifBAy/EbFQkhLZW4i177d0C5V53Dc8ORSg gbcQ== X-Gm-Message-State: AIkVDXJhtljvpgjx/r5WQRCtjkKZPccNJgQ+OEmbjdCCiUFuawcGjNszIjC6XA8TqrTTKeNf X-Received: by 10.28.87.16 with SMTP id l16mr8123423wmb.111.1482412227815; Thu, 22 Dec 2016 05:10:27 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id e5sm32128148wma.12.2016.12.22.05.10.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 05:10:27 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Tomasz Kulasek , "Ananyev, Konstantin" Date: Thu, 22 Dec 2016 14:10:26 +0100 Message-ID: <3100044.IZmX6DqlTf@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3c86020d-b81f-bbe0-4cfc-746f7714af01@intel.com> References: <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com> <1481650914-40324-7-git-send-email-tomaszx.kulasek@intel.com> <3c86020d-b81f-bbe0-4cfc-746f7714af01@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v13 6/7] vmxnet3: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 13:10:28 -0000 2016-12-20 13:36, Ferruh Yigit: > On 12/13/2016 5:41 PM, Tomasz Kulasek wrote: > > From: "Ananyev, Konstantin" > > > > Signed-off-by: Konstantin Ananyev > > --- > > <...> > > > > > uint16_t > > +vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, > > + uint16_t nb_pkts) > > +{ > <...> > > + > > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > > + ret = rte_validate_tx_offload(m); > > + if (ret != 0) { > > + rte_errno = ret; > > + return i; > > + } > > +#endif > > + ret = rte_net_intel_cksum_prepare(m); > > Since this API used beyond Intel drivers, what do you think renaming it? > rte_net_generic_cksum_prepare() ? I think it is good to have Intel in its name because it is where it comes from. Hopefully we won't have to care about this specific API when tx_prepare will be well accepted.