* [dpdk-dev] [PATCH] log: add missing symbol
@ 2015-12-17 0:38 Stephen Hemminger
2015-12-17 11:20 ` Neil Horman
2016-01-27 9:35 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2015-12-17 0:38 UTC (permalink / raw)
To: dev
rte_get_log_type and rte_get_log_level functions has been avaliable
for many versions. But they are missing from the shared library map
and therefore do not get exported correctly.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index cbe175f..51a241c 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -93,7 +93,9 @@ DPDK_2.0 {
rte_realloc;
rte_set_application_usage_hook;
rte_set_log_level;
+ rte_get_log_level;
rte_set_log_type;
+ rte_get_log_type;
rte_socket_id;
rte_strerror;
rte_strsplit;
--
2.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] log: add missing symbol
2015-12-17 0:38 [dpdk-dev] [PATCH] log: add missing symbol Stephen Hemminger
@ 2015-12-17 11:20 ` Neil Horman
2016-01-27 9:35 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Neil Horman @ 2015-12-17 11:20 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Wed, Dec 16, 2015 at 04:38:34PM -0800, Stephen Hemminger wrote:
> rte_get_log_type and rte_get_log_level functions has been avaliable
> for many versions. But they are missing from the shared library map
> and therefore do not get exported correctly.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index cbe175f..51a241c 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -93,7 +93,9 @@ DPDK_2.0 {
> rte_realloc;
> rte_set_application_usage_hook;
> rte_set_log_level;
> + rte_get_log_level;
> rte_set_log_type;
> + rte_get_log_type;
> rte_socket_id;
> rte_strerror;
> rte_strsplit;
> --
> 2.1.4
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] log: add missing symbol
2015-12-17 0:38 [dpdk-dev] [PATCH] log: add missing symbol Stephen Hemminger
2015-12-17 11:20 ` Neil Horman
@ 2016-01-27 9:35 ` Thomas Monjalon
2016-02-29 15:05 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-01-27 9:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2015-12-16 16:38, Stephen Hemminger:
> rte_get_log_type and rte_get_log_level functions has been avaliable
> for many versions. But they are missing from the shared library map
> and therefore do not get exported correctly.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> 1 file changed, 2 insertions(+)
Why only in linuxapp?
> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index cbe175f..51a241c 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -93,7 +93,9 @@ DPDK_2.0 {
> rte_realloc;
> rte_set_application_usage_hook;
> rte_set_log_level;
> + rte_get_log_level;
> rte_set_log_type;
> + rte_get_log_type;
We try to keep an alphabetical order :)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] log: add missing symbol
2016-01-27 9:35 ` Thomas Monjalon
@ 2016-02-29 15:05 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-02-29 15:05 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2016-01-27 10:35, Thomas Monjalon:
> 2015-12-16 16:38, Stephen Hemminger:
> > rte_get_log_type and rte_get_log_level functions has been avaliable
> > for many versions. But they are missing from the shared library map
> > and therefore do not get exported correctly.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Why only in linuxapp?
>
> > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > index cbe175f..51a241c 100644
> > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > @@ -93,7 +93,9 @@ DPDK_2.0 {
> > rte_realloc;
> > rte_set_application_usage_hook;
> > rte_set_log_level;
> > + rte_get_log_level;
> > rte_set_log_type;
> > + rte_get_log_type;
>
> We try to keep an alphabetical order :)
Reordered, updated in bsdapp/ and
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-29 15:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-17 0:38 [dpdk-dev] [PATCH] log: add missing symbol Stephen Hemminger
2015-12-17 11:20 ` Neil Horman
2016-01-27 9:35 ` Thomas Monjalon
2016-02-29 15:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).