From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 651768E6C for ; Tue, 3 Nov 2015 00:48:08 +0100 (CET) Received: by wmec75 with SMTP id c75so73625441wme.1 for ; Mon, 02 Nov 2015 15:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=rop72WNkT/YNmJKCQpMPoJMKoqJbIFlfZRq6Md2UlfQ=; b=vaUQR+Zw8ctUwiEpF8mzxmlIRcIryMopnmqTTzR5Ahmv7hOllRHy4jBJ2OHO5tFa9R olbz1TuMzP8fRnBBmCheKb/D0BELV5orTCZyJ8bCOafJt3MqXM5LEW/4x0hPD02/KaZh p04a4ZHkHuTpapqnVNmpc8zUAAxJmufuDH0xBFBFF6C6Nzls97o1idygavSxvYpdb3Ys STCCvjlZy7sZR1pzqMNMqtEGozYi/In3ecQmLM1cY7Wua7Uk6E17Ydaa89bhwak3A4aN Mib6QF2K08TWPXWbXf8a8Ew8+EWKRwgpoRXMiPrm/UaYi/v3yv9Ic9yOiSdnm/nK+XAW fNXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=rop72WNkT/YNmJKCQpMPoJMKoqJbIFlfZRq6Md2UlfQ=; b=QOkK6KOiHXyjf+hoMcGynHr2YE8WN7Fmfj1ITm6A6K29CrZEHVWGfCRtBjS6CbSQVG XxHG5Rafu9YGgtQi4Tm7P7hp3YKdGVkv5J2AJE0uMlKRGzHW1VCkHf3MdD60+kV8zUNw hjrVY+PmXyv4nJdmZAU2HzkwY7jzE600UITv0grYWtv66fRyiTuCo+zsxdE840qJfloW l4X7PXFe2iatlQs9E7XOiBE8j4FDtiL/9vJtv4Qepb8kiwq37TtVFaJREF3nNnADc1bc XTYaKtFzbHz22dp50xm+Ql7FsJnUlr5lSrdiNSIMoGhXSnk/hn7Kd5tKtXvU1Rne3tPe yiZg== X-Gm-Message-State: ALoCoQllUYu00Pg19fNsvbvTQaiSe0Mk7Hhzho8CBTkfU78saMJL6OhFbJow4ZdLH9RINYCGRxFy X-Received: by 10.28.134.134 with SMTP id i128mr17287747wmd.50.1446508088262; Mon, 02 Nov 2015 15:48:08 -0800 (PST) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id l131sm20669479wmd.14.2015.11.02.15.48.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 15:48:07 -0800 (PST) From: Thomas Monjalon To: Maryam Tahhan Date: Tue, 03 Nov 2015 00:46:57 +0100 Message-ID: <3108772.cu7MlmvWl0@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com> References: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and error stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 23:48:08 -0000 2015-10-19 13:20, Maryam Tahhan: > Make a distniction between dropped packets and error statistics to allow > a higher level fault management entity to interact with DPDK and take > appropriate measures when errors are detected. It will also provide > valuable information for any applications that collects/extracts DPDK > stats, such applications include Open vSwitch. > After this patch the distinction is: > ierrors = Total number of packets dropped by hardware (malformed > packets, ...) Where the # of drops can ONLY be <= the packets received > (without overlap between registers). > ipkterrors = Total number of erroneous received packets. Where the # > of errors can be >= the packets received (without overlap between > registers), this is because there may be multiple errors associated with > a packet. [...] > - uint64_t ierrors; /**< Total number of erroneous received packets. */ > + uint64_t ierrors; > + /**< Total number of packets dropped by hardware (malformed packets...) > + * Where the # of drops can ONLY be <= the packets received (without > + * overlap between registers). > + */ > uint64_t oerrors; /**< Total number of failed transmitted packets. */ > + uint64_t ipkterrors; > + /**< Total number of erroneous received packets. Where the number of > + * errors can be >= the packets received (without overlap between > + * registers), this is because there may be multiple errors associated with > + * a packet. > + */ There was not a lot of comments on this proposal. If the idea is well received, it needs to be implemented in drivers, at least few of them.