From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 955075592
for <dev@dpdk.org>; Mon, 25 Sep 2017 11:59:35 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Sep 2017 02:59:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="1223312309"
Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.44])
([10.237.220.44])
by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2017 02:59:33 -0700
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Marjanovic, Nemanja" <nemanja.marjanovic@intel.com>,
"Sexton, Rory" <rory.sexton@intel.com>
References: <1503676941-80981-1-git-send-email-david.hunt@intel.com>
<1503676941-80981-3-git-send-email-david.hunt@intel.com>
<9BB6961774997848B5B42BEC655768F810E7C817@SHSMSX103.ccr.corp.intel.com>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <31090ab8-928f-bd80-bd04-2889cb6342bf@intel.com>
Date: Mon, 25 Sep 2017 10:59:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E7C817@SHSMSX103.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v1 02/10] net/i40e: add API to get received
packet count
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Sep 2017 09:59:36 -0000
On 25/9/2017 3:47 AM, Wu, Jingjing wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
>> Sent: Saturday, August 26, 2017 12:02 AM
>> To: dev@dpdk.org
>> Cc: Hunt, David <david.hunt@intel.com>; Marjanovic, Nemanja
>> <nemanja.marjanovic@intel.com>; Sexton, Rory <rory.sexton@intel.com>
>> Subject: [dpdk-dev] [PATCH v1 02/10] net/i40e: add API to get received packet
>> count
>>
>> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
>> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>> drivers/net/i40e/i40e_ethdev.c | 1 +
>> drivers/net/i40e/i40e_rxtx.c | 10 ++++++++++
>> drivers/net/i40e/i40e_rxtx.h | 1 +
>> lib/librte_ether/rte_ethdev.h | 19 +++++++++++++++++++
>> 4 files changed, 31 insertions(+)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 8fb67d8..d9806fc 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -446,6 +446,7 @@ static const struct rte_pci_id pci_id_i40e_map[] = {
>>
>> static const struct eth_dev_ops i40e_eth_dev_ops = {
>> .vfid_to_pfid = i40e_vf_mac_to_vsi,
>> + .read_pf_stats = i40e_vsi_stats_read,
>> .dev_configure = i40e_dev_configure,
>> .dev_start = i40e_dev_start,
>> .dev_stop = i40e_dev_stop,
>> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
>> 1379d5e..b7b64d2 100644
>> --- a/drivers/net/i40e/i40e_rxtx.c
>> +++ b/drivers/net/i40e/i40e_rxtx.c
>> @@ -833,6 +833,16 @@ i40e_vf_mac_to_vsi(struct rte_eth_dev *dev, uint64_t
>> vfid) {
>> return -1;
>> }
>>
>> +uint64_t
>> +i40e_vsi_stats_read(struct rte_eth_dev *dev, uint8_t vsi_id) {
>> + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data-
>>> dev_private);
>> +
>> + uint64_t glv_uprch = I40E_READ_REG(hw,
>> + I40E_GLV_UPRCH(vsi_id)) & 0x0000FFFF;
>> + uint64_t glv_uprcl = I40E_READ_REG(hw, I40E_GLV_UPRCL(vsi_id));
>> + return glv_uprcl + (glv_uprch << 32);
>> +}
> You can change the input to vf_id, and then get the vsi_id internally.
> Anyway, the counter registers are cleared when read. It will impact the
> Ops like stats_get/ stats_reset.
>
> We have func called i40e_update_vsi_stats which record the packets count. I think you can use it.
>
>
> Thanks
> Jingjing
We've changed to using the existing stats functions in the next revision
of the patch. Simplifies things a bit.
Thanks,
Dave