From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4C5FC200; Fri, 25 May 2018 10:30:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D82B322398; Fri, 25 May 2018 04:29:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 25 May 2018 04:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=w8dAlPzHvjuiNLG7y6VP77kXc0 2/5V9C56IAQ0llboQ=; b=VC0QqD3Japqku1535JYGzeiuMCkQQ5aU34QG/0lw+e BcyPuLjEd23KNjcYpkaVq9Z4PfC7CQd4yNUJxPcEz/jndaYaXOPU0RqGqeG15ihx oEbwe1KOjPyoAHRk4N0sm3/NjGi/6ucaI/GmdHJIwjRNDySY1RBZxWOztWe2RtqM U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=w8dAlP zHvjuiNLG7y6VP77kXc02/5V9C56IAQ0llboQ=; b=kP1hzLQsyzNMyWTlSjvr+Q LUTk5d6MBWMOzVrTUQrZ+/Wyh6QUGNq72lCxyg9awaHYg90FWB3f+wimkMQgpEc8 6f7+Zpoi/tsfa/mJ3pVIaL99m9s/Nckno4GXerkSohzCkmQbuSUB0kTp+jNyw5By VDf+R1BZi5prtObpdl/MYYYCAhiqhjgUNVRKEWmhb3YahRc1+C/vRkON9B9OZQmC RfVe3QMSxWl/KbSVlLkfPQInmGuQ2vg9bYxN05jnRT+ueSEX5SVDZhifEHJIgkJC jsqQCW3EwrOzvnSJxsH4803EUDU1r60AHwqOZFpKkVf2Uch+biug8Ftl5+/FjXeg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AA607E42DB; Fri, 25 May 2018 04:29:53 -0400 (EDT) From: Thomas Monjalon To: Ophir Munk , ferruh.yigit@intel.com Cc: stable@dpdk.org, dev@dpdk.org, Pascal Mazon , Keith Wiles , Olga Shern , Shahaf Shuler Date: Fri, 25 May 2018 10:29:52 +0200 Message-ID: <3109491.7GuuFblrTl@xps> In-Reply-To: <1527203440-29861-1-git-send-email-ophirmu@mellanox.com> References: <1527203440-29861-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix keep-alive queue not detached X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 08:30:33 -0000 25/05/2018 01:10, Ophir Munk: > The TAP keep-alive queue was created in order to keep the TAP device > in Linux even in case all of its Rx/Tx queues are released (in Linux > terminology: even in case all of the TAP device file descriptors are > closed), however, the keep-alive queue itself is attached to the TAP > device like all other Rx/Tx queues and therefore the kernel will > enqueue to it some Rx packets based on the kernel RSS distribution > rules. Those packets are unknown to the application and will remain > lost in the keep-alive queue. > All queues are attached by default to the TAP device after they are > created though TUNSETIFF ioctl call. > The fix is to detach the keep-alive queue after its creation through > TUNSETQUEUE ioctl call. > > Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk > --- > drivers/net/tap/rte_eth_tap.c | 33 +++++++++++++++++++++++++++------ > 1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 310c7d8..c3af608 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -95,13 +95,20 @@ enum ioctl_mode { > > static int tap_intr_handle_set(struct rte_eth_dev *dev, int set); > > -/* Tun/Tap allocation routine > +/** > + * Tun/Tap allocation routine > + * > + * @param[in] pmd > + * Pointer to private structure. > + * > + * @param[in] is_keepalive > + * Keepliave flag Typo: Keepliave -> Keepalive Ferruh, please can you fix it? Or just remove all the doxygen comments? Note: this fix is critical. Without it, some flows are lost.