From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9527D2906 for ; Thu, 3 Mar 2016 11:38:04 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l68so25695428wml.1 for ; Thu, 03 Mar 2016 02:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=mJmoy0JGEvOaBCYkfzRx9Rx8Hf+XuUdOnX5aJkkoQSY=; b=UJr+vR2w2qH090QQPuSL24Q7zXvAJ2MEQGj5eZVhRqxxqxsT/VgELAlan8UaFZbmh3 FtFjHgy7i3Pvftqh9OeWJ35yEBO7jCUPHOpGgw2CB1QTu/NY3JQbSWM8iSs8Gx9roXRd x8D6bFVDoMqQN1gmBmgczFBQPwiq8gbAE6t4WgDblGyaIo7P/8893/T+cjJyYVE0C/nY FwDOrOOPYj2Se7qphiVUJyQTpFsNRoVIRYlzGgpzK11iB4Wsv6b6OXFyy/JQBs8pSxo+ 4UPqLcdVUR0BbpF2HxHdb6ULKHgIxN9I5hQ+zm36aI1zi9RTT5wtCBUytn7XnmQ7KCT5 OoVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=mJmoy0JGEvOaBCYkfzRx9Rx8Hf+XuUdOnX5aJkkoQSY=; b=Liy7FWLhgXYMspZ/e1i5OJ01wO8Q4M0skU/M6iGFgCCf1fLH7LK2oSQiq9xIhX7ddP y9LnOF6E52JRreNc4Ua0Gq83aBE4ahlA0J0lg6pMfbCDWxZgXUBGkMsdAZ/D4QHcEe2A 6OYbyAJPud2BoqE28t4O/5jBQL9oWX4/PIA6dzbjt5Gk449wCGaBMu7uFfoLtuUW0Say 5ggtfUBA+/Z9YggZYfYO/VSN3CI3odJ/0jyTRN96GlvQ8LongevznahUHHT5YSv9yLAE S5H05I4SwKe/VMlUp21zWoBzjirU9+ZTMup//N7viH3OipGjGkziYd4W9j4D37LIdVDQ xyvQ== X-Gm-Message-State: AD7BkJLg1/ZOENBQ7qn1UarfuQkL8x1JlaSHQ1tgxXM5dLfOk3scwoncU+1PefXcmYWKDTs4 X-Received: by 10.194.179.168 with SMTP id dh8mr2517554wjc.130.1457001484474; Thu, 03 Mar 2016 02:38:04 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ka4sm40019583wjc.47.2016.03.03.02.38.03 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2016 02:38:03 -0800 (PST) From: Thomas Monjalon To: pmatilai@redhat.com Date: Thu, 03 Mar 2016 11:36:28 +0100 Message-ID: <3110515.Sqe0BZWodk@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160302220453.GE8804@bricha3-MOBL3> References: <9190554.3JBlDK3N1R@xps13> <1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com> <20160302220453.GE8804@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 10:38:04 -0000 2016-03-02 22:04, Bruce Richardson: > On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote: > > From: Panu Matilainen > > > > Add RTE_DEVEL_BUILD make-variable which can be used to do things > > differently when doing development vs building a release, > > autodetected from source root .git presence and overridable via > > commandline. It is used it to enable -Werror compiler flag and may > > be extended to other checks. > > > > Failing build on warnings is a useful developer tool but its bad > > for release tarballs which can and do get built with newer > > compilers than what was used/available during development. Compilers > > routinely add new warnings so code which built silently with cc X > > might no longer do so with X+1. This doesn't make the existing code > > any more buggier and failing the build in this case does not help > > to improve the quality of an already released version either. > > > > This change the default flags which can be tuned with EXTRA_CFLAGS. > > > > Signed-off-by: Panu Matilainen > > Signed-off-by: Thomas Monjalon > > Acked-by: Bruce Richardson Applied, thanks If people have problems compiling previous releases, please remind to use EXTRA_CFLAGS=-Wno-error