DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ipsec: fix build dependency on hash lib
@ 2020-04-16 11:25 Akhil Goyal
  2020-04-16 12:19 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Akhil Goyal @ 2020-04-16 11:25 UTC (permalink / raw)
  To: thomas, dev; +Cc: david.marchand, ferruh.yigit, rasland, Akhil Goyal

rte_ipsec has a dependancy on rte_hash
So we need the librte_hash to be compiled before librte_ipsec.
Add the DEPDIRs to make sure this.

Fixes: 3feb23609cae ("ipsec: add SAD create/destroy implementation")
Cc:stable@dpdk.org

Reported-by: Raslan Darawsheh <rasland@mellanox.com>
Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Makefile b/lib/Makefile
index 46b91ae1a..2cbb096f1 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -113,7 +113,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_BPF) += librte_bpf
 DEPDIRS-librte_bpf := librte_eal librte_mempool librte_mbuf librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_IPSEC) += librte_ipsec
 DEPDIRS-librte_ipsec := librte_eal librte_mbuf librte_cryptodev librte_security \
-			librte_net
+			librte_net librte_hash
 DIRS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += librte_telemetry
 DEPDIRS-librte_telemetry := librte_eal librte_metrics librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_RCU) += librte_rcu
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] ipsec: fix build dependency on hash lib
  2020-04-16 11:25 [dpdk-dev] [PATCH] ipsec: fix build dependency on hash lib Akhil Goyal
@ 2020-04-16 12:19 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-04-16 12:19 UTC (permalink / raw)
  To: Akhil Goyal; +Cc: dev, david.marchand, ferruh.yigit, rasland

16/04/2020 13:25, Akhil Goyal:
> rte_ipsec has a dependancy on rte_hash

dependency

> So we need the librte_hash to be compiled before librte_ipsec.
> Add the DEPDIRs to make sure this.
> 
> Fixes: 3feb23609cae ("ipsec: add SAD create/destroy implementation")
> Cc:stable@dpdk.org

missing a space after :

> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-16 12:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 11:25 [dpdk-dev] [PATCH] ipsec: fix build dependency on hash lib Akhil Goyal
2020-04-16 12:19 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).