From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 20F7F3576 for ; Tue, 2 Apr 2019 02:20:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AA22622257; Mon, 1 Apr 2019 20:20:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 20:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3OId2Bedkp0PVPyWrDJezs48IksJwDdvhTSdMw2xrZ8=; b=SZLzPv0O4qTP VXTK9aWmPYuNvry09LMZ4XBTRZwvKRS69ooHfRl76oowtiJ/pdRgFFPINw3InOga u3M+E9sT8nL+iOj+WiiNINjjo4jyUWFbWtM9mxb3OTiAxS/0GZf0YwwWvhOGA65g o0fTDsh6bVbflQfWto6ugTRnbZVQLCM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3OId2Bedkp0PVPyWrDJezs48IksJwDdvhTSdMw2xr Z8=; b=7O/5Byxi6pLKdwovF1yYhAhYv8ZZCHUXSWZFcIEajVt+mSairMiiFglIq 7NgpE6k9PhJdqxucOKG0wuQ9EMG+Pq49j3cQpyQTAz+LEMOZcWhU0DYYiYepZDMd tNWVrIfChU1h+eW6Ngtzty9D/0HYHOjPE5JdNGCeZKlMicmsxQQGVC/ywbnMRLlz YWm8qTT4FkGuycjoLRvKeF09KhlmIMk3/WcWTett8mduVWMQdBLJBWpRvXMXxuJa ZswbOyJRiISXQBX1BWybaOgl4BEWY12CfY6yHB5gblwgoumj9jiUG89F5D5Nues5 kn/iX9sbMklofrA1/RR4esyXHodOA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BCB110311; Mon, 1 Apr 2019 20:20:29 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, anatoly.burakov@intel.com, liang.j.ma@intel.com Date: Tue, 02 Apr 2019 02:20:28 +0200 Message-ID: <3122998.i2pmggpM1V@xps> In-Reply-To: <2066148.uFblHQ0ktz@xps> References: <20190401153044.39273-1-david.hunt@intel.com> <20190401161441.29328-2-david.hunt@intel.com> <2066148.uFblHQ0ktz@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 2/2] examples/distributor: detect high frequency cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 00:20:31 -0000 02/04/2019 02:06, Thomas Monjalon: > 01/04/2019 18:14, David Hunt: > > The distributor application is bottlenecked by the distributor core, > > so if we can give more frequency to this core, then the overall > > performance of the application may increase. > > > > This patch uses the rte_power_get_capabilities() API to query the > > cores provided in the core mask, and if any high frequency cores are > > found (e.g. Turbo Boost is enabled), we will pin the distributor > > workload to that core. > > > > Signed-off-by: Liang Ma > > Signed-off-by: David Hunt > > Reviewed-by: Anatoly Burakov > > Series applied, thanks Just amended the commit with this fix: --- a/examples/Makefile +++ b/examples/Makefile +ifeq ($(CONFIG_RTE_LIBRTE_POWER),y) DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += distributor +endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1FD8CA0679 for ; Tue, 2 Apr 2019 02:20:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13D4837A8; Tue, 2 Apr 2019 02:20:32 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 20F7F3576 for ; Tue, 2 Apr 2019 02:20:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AA22622257; Mon, 1 Apr 2019 20:20:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 20:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3OId2Bedkp0PVPyWrDJezs48IksJwDdvhTSdMw2xrZ8=; b=SZLzPv0O4qTP VXTK9aWmPYuNvry09LMZ4XBTRZwvKRS69ooHfRl76oowtiJ/pdRgFFPINw3InOga u3M+E9sT8nL+iOj+WiiNINjjo4jyUWFbWtM9mxb3OTiAxS/0GZf0YwwWvhOGA65g o0fTDsh6bVbflQfWto6ugTRnbZVQLCM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3OId2Bedkp0PVPyWrDJezs48IksJwDdvhTSdMw2xr Z8=; b=7O/5Byxi6pLKdwovF1yYhAhYv8ZZCHUXSWZFcIEajVt+mSairMiiFglIq 7NgpE6k9PhJdqxucOKG0wuQ9EMG+Pq49j3cQpyQTAz+LEMOZcWhU0DYYiYepZDMd tNWVrIfChU1h+eW6Ngtzty9D/0HYHOjPE5JdNGCeZKlMicmsxQQGVC/ywbnMRLlz YWm8qTT4FkGuycjoLRvKeF09KhlmIMk3/WcWTett8mduVWMQdBLJBWpRvXMXxuJa ZswbOyJRiISXQBX1BWybaOgl4BEWY12CfY6yHB5gblwgoumj9jiUG89F5D5Nues5 kn/iX9sbMklofrA1/RR4esyXHodOA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BCB110311; Mon, 1 Apr 2019 20:20:29 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, anatoly.burakov@intel.com, liang.j.ma@intel.com Date: Tue, 02 Apr 2019 02:20:28 +0200 Message-ID: <3122998.i2pmggpM1V@xps> In-Reply-To: <2066148.uFblHQ0ktz@xps> References: <20190401153044.39273-1-david.hunt@intel.com> <20190401161441.29328-2-david.hunt@intel.com> <2066148.uFblHQ0ktz@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 2/2] examples/distributor: detect high frequency cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402002028.mViOYa5vEWlpng7-nMw4UBWx3yecUHJ9wGeDwOtE-PU@z> 02/04/2019 02:06, Thomas Monjalon: > 01/04/2019 18:14, David Hunt: > > The distributor application is bottlenecked by the distributor core, > > so if we can give more frequency to this core, then the overall > > performance of the application may increase. > > > > This patch uses the rte_power_get_capabilities() API to query the > > cores provided in the core mask, and if any high frequency cores are > > found (e.g. Turbo Boost is enabled), we will pin the distributor > > workload to that core. > > > > Signed-off-by: Liang Ma > > Signed-off-by: David Hunt > > Reviewed-by: Anatoly Burakov > > Series applied, thanks Just amended the commit with this fix: --- a/examples/Makefile +++ b/examples/Makefile +ifeq ($(CONFIG_RTE_LIBRTE_POWER),y) DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += distributor +endif