From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E122CA0527;
Mon, 9 Nov 2020 18:09:58 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id BDCD86889;
Mon, 9 Nov 2020 18:09:56 +0100 (CET)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 974766004
for <dev@dpdk.org>; Mon, 9 Nov 2020 18:09:54 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 263B75C03F6;
Mon, 9 Nov 2020 12:09:53 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Mon, 09 Nov 2020 12:09:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
VSgn0kDutRDW2CNqxVGoqw95gaCw2ULrRDs1bSrUDcA=; b=MrHsyegnalnIREbD
UBFsWs/V19YnsxCpMwiUNRJqyuywQf5HN9ty3xBkBMgGfSPcUa/0Kh9fzAtF5b1O
JbM2YTB8bfjuPNGg+RaogajdWZpYwoxzBfgZYcy1GursnLzR3y/trM5vbxkjMObI
EPcwkBOiTCMASsWX8TUoe75QJIrkSFrASNlfyUlg0HvaP4BAgenxHkVW4DyNEdZs
Ev1s7PTF0WuoKh5BtebRcEf6tEg8kv6HDnVE1HmFlr6LBeBUoEb6LDKDEq7l/jEZ
lC7+iebzRzPG9yKj4w9senFozDApbHFgf+Z7Roj2fadoZEVpRu5xuO3R1G27RePT
hHNEHw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=VSgn0kDutRDW2CNqxVGoqw95gaCw2ULrRDs1bSrUD
cA=; b=qLSYzTLCidjN5esNFT3//LR7atXn+auXY1ugWVpOrE3wv2NNy4kFP1t8M
7xrxFwe78g3bXa8lnh9k6MBQPtrrUp4vXdqG1iVlOFGAHH7Ngmxv//1+/WNhZaT6
Fqr/i3r26wkpV2j4j9ANNkXryXprZx+J6wc1+hUSWiB7hJ/zx/WZXTXkk9vmJ4C9
rsBzOqVl20NcN1bnkGHfq7nKlY928ZBPZKH7JMdTMQal1hpYSq3eihhIbRkUgGfY
zQmIVbnvjZWcCvejrrw4b2uneiu8ssqa1CpL+HbzvpPhDUzAKEWKXYjWpU92M56k
fQN9NLvMUvh/eWw8Hy9Ikt/9Ov/Mg==
X-ME-Sender: <xms:4HepX17RpcsCoEOuzFCDoTD9NCnAtIbeaSJYbaMmUjDnfYST4HE7KQ>
<xme:4HepXy61Un5ksjf4f2JR73TUguAH8nR6ZdB2duqikEoHdHcWPWSMPkxbB10dyhx2V
BiBaF1m3jeYzfP4Yg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduhedgleelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:4HepX8fQxvnEH8wAaNiV25IFKFVX2gcssGcT8tU1tUr9W2TM8v6hAA>
<xmx:4HepX-IakUdnWA1eqC9IdwNsQHTgAZebp_it0uvc4diSeYvBMVBblg>
<xmx:4HepX5JCi9f4-I5kq4st_KXO99BN869vVcViqF3gkDlh_ZceQA5w3g>
<xmx:4XepX7yfXJx8pz4Hpwxfe_UQ5VV3T0SKsmXWlVJFDh4jsN6ogg2QFg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 43222306307F;
Mon, 9 Nov 2020 12:09:52 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Date: Mon, 09 Nov 2020 18:09:51 +0100
Message-ID: <3123472.p7xLvF2YS7@thomas>
In-Reply-To: <20201027173836.891184-1-bruce.richardson@intel.com>
References: <20201027173836.891184-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set
of examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
27/10/2020 18:38, Bruce Richardson:
> To test the installation process of DPDK using "ninja install"
> test-meson-builds.sh builds a subset of the examples using "make". To allow
> more flexibility for people testing, allow the set of examples chosen for
> this make test to be overridden using variable "DPDK_BUILD_TEST_EXAMPLES"
> in the environment.
>
> Since a number of example apps link against drivers directly even for
> shared builds, we need to ensure that LD_LIBRARY_PATH points to the main
> DPDK lib folder so any dependencies of those drivers can be found e.g. that
> the PCI/vdev bus driver .so is found. [All drivers are symlinked from
> drivers dir back to lib dir on install, so only one dir rather than two is
> needed in the path.]
[...]
> +libdir=$(dirname $(find $DESTDIR -name librte_eal.so))
> +export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH
I don't get why libdir is required for some examples,
and not for others? The pkg-config file is not enough?
> +examples_to_test=${DPDK_BUILD_TEST_EXAMPLES:-"cmdline helloworld l2fwd l3fwd skeleton timer"}
It makes me think that we should rename TEST_MESON_BUILD_VERY_VERBOSE
to DPDK_BUILD_TEST_VERY_VERBOSE for consistency.