From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CE96A04DD; Tue, 10 Nov 2020 18:55:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5FA737B1; Tue, 10 Nov 2020 18:55:52 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id AEFB537B1; Tue, 10 Nov 2020 18:55:50 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 76522138B; Tue, 10 Nov 2020 12:55:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 10 Nov 2020 12:55:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= FQyIAVqH6oel7LLCba4rZ/L7CbuhMXhERGVg7a6ysTc=; b=ia3wwBtoFJ82GPZk EMcAAm1ylkHmDlQPWeY36cATRuUlKSLiltVMJ4xdDOX9M4o0x4naEgUdw4ysbMTU h2bBG9KIcblu6bY6iMZwqHHVvNEQOkdIOcYE7ArWPOnNMU0erle7eKMNoezAGzqR MssgTo0c58slmKDBmZlj6aqtikl+b1lWZ1zU4hEmvE8bnImVapsY3FL3fJM4aiNJ QT7grDrI8xJWpPaLYx4J5hSrCuLOgmLvb3LPnTLp8tQs0zaq316Z1SboYW+WIBcM RYZki0mHdMEWWn2iVWXytUoVe0xAb/7+HKOMf6Qg1HUInq/nenaREaxcR0zsXhF7 Ppqepw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FQyIAVqH6oel7LLCba4rZ/L7CbuhMXhERGVg7a6ys Tc=; b=oQUiHir5CsgzkvHpMZWlTAn8+V12XL9fpV5d+iD5Q0Rj2gj08UihAtxeW ziFqbujfvUiakjMNKuKxXIdH9HhzKm79nrq3XJCsWSyLVCLQD3UUgInrPGbdVuBm IVvfovpK91vzEUE83x7HFzOYmBkpGh1UiqS5MJELxHuNSkdTxVY35KAco1iUrrgF //SNvfOSQaq/ZSwqQO6oWKPEDpYjWBdi6mfwjeutZNSPWgt6tPfl3ZBlqr0sLBe6 gjcCg2EAomwbvCRop4I6UedSfR9JBMYPwO/om6aopQArfwbGdQmCzY73ZIf+zCjy nd7tb1RP68b4shovgZQtlYB6+PTvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddujedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 306083280068; Tue, 10 Nov 2020 12:55:44 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stable@dpdk.org, Luca Boccassi Date: Tue, 10 Nov 2020 18:55:35 +0100 Message-ID: <3123620.zLnPt8Nx3Z@thomas> In-Reply-To: References: <20201109210009.919129-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/11/2020 18:18, Ferruh Yigit: > On 11/9/2020 9:00 PM, Thomas Monjalon wrote: > > PKG_CONFIG_PATH is specific to each target, so it must be empty > > before configuring each build from the file according to DPDK_TARGET. > > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense > > and is prone to confusion. [...] > In same run both 64bit and 32bit builds are done, Multiple targets can be built yes. > At least for my environment, > for 64bit, PKG_CONFIG_PATH should be '/usr/local/lib64/pkgconfig/' > for 32bit, PKG_CONFIG_PATH should be '/usr/lib/pkgconfig/' Not sure you need to set these values in PKG_CONFIG_PATH. At least /usr/lib/pkgconfig/ is already set in PKG_CONFIG_LIBDIR. Let me rephrase the man page of pkg-config: PKG_CONFIG_LIBDIR is the primary paths list PKG_CONFIG_PATH is the secondary paths list > What should I set in the config file to support both? The standard paths for your 64-bit machine should be built-in in your pkg-config. The standard path for 32-bit is already set automatically in devtools/test-meson-builds.sh. Only additional specific paths should be set in a config file. What is a config file? It is loaded by devtools/load-devel-config: - /etc/dpdk/devel.config (system-wide) - or ~/.config/dpdk/devel.config (user config) - or .develconfig (project directory config) Personally I set all my configs in ~/.config/dpdk/devel.config. Note that the same file is used to configure multiple tools. For each build, some variables are reset the variable DPDK_TARGET is set, and the config file is sourced. The typical values of DPDK_TARGET are: - i386-pc-linux-gnu - x86_64-pc-linux-gnu - x86_64-w64-mingw32 - aarch64-linux-gnu - powerpc64le-linux-gcc TLDR, I assume you just want to set an additional 64-bit path, so the config file should look like: if [ "$DPDK_TARGET" = x86_64-pc-linux-gnu ] ; then export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/usr/local/lib64/pkgconfig fi