From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1B59A00C5; Sun, 5 Jul 2020 22:39:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC1B11DA27; Sun, 5 Jul 2020 22:39:38 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1DAD71DA0F for ; Sun, 5 Jul 2020 22:39:37 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A94465C00B8; Sun, 5 Jul 2020 16:39:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 16:39:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= PvOfgx+DtoAsiGMvhOo2Rf1w0lxr2UJefPaoa9MkJEE=; b=qjWvh6KDM+ktwgg4 7ozIlh5Nc3+L6hS91wlFvNR0u7O1Sn2ZEvsGi7H1iInqUFSRp21ck8wuSbhdRtnL 9w0YT0b/RI0PfljUw0YW05eV2zXr5pkVPOqQvJn5e8rd0LQWzgrKEYfdqdvPfpve 5SJY5pwxEBMQj9cJpLV8NrjNRRjOru2e51lnK2515ITUF5PQSezsws4Ri0svvxkZ SWtlUiFTTrwiczykb+U9Z2TlzLpcPRBwVQ58vU10HH4VVCPA0DzvkMImrqT+VcOz AP6C5xtghvOlOW4EkcIlzj6jx0SjIRGnnnXcz7FI2gQCJp5k/mK4jSzbBNdX2w6y 1vaYAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PvOfgx+DtoAsiGMvhOo2Rf1w0lxr2UJefPaoa9MkJ EE=; b=R8gSJYfPfxHef1E5iFPzyh5AlkeXalbZklwk6UfMU0WZppRbkfTihKa3F 0/WrpcIqtJqUhrubOPoEezw6mHVfzhdqQ0Lvd9UP1o1BpT4PlaGYxkbPxz7BTDcR RXp09e4B3PJEVo13KUsQPXCstH5P4UyTj2acaMkfmgQYMuxypQikg8xzS9/ISwxv nsYTCzqKEVjSW7hG8O5czaDRQUB04vJNHyzliN1Fgj516E9jNGM1SP4mbt1XgDk/ j48cTQgGs9QJqybxE/eXlr5PVcbraobTgY/8HY38K29aXq6iRA3JI4Z+A1pe6JSj UPi0WDB6m4vsZBKfc/YpvAmGRQbQQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A6AC53280063; Sun, 5 Jul 2020 16:39:35 -0400 (EDT) From: Thomas Monjalon To: Wisam Jaddo Cc: jackmin@mellanox.com, david.marchand@redhat.com, dev@dpdk.org, asafp@mellanox.com, arybchenko@solarflare.com Date: Sun, 05 Jul 2020 22:39:34 +0200 Message-ID: <31256849.VAYTUQ5BGV@thomas> In-Reply-To: <20200630081028.21339-1-wisamm@mellanox.com> References: <20200630081028.21339-1-wisamm@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/06/2020 10:10, Wisam Jaddo: > The hairpin queue is the one that start from normal rxq, > and will be less than nr_queues where nr_queues is the > sum of normal and hairpin > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wisamm@mellanox.com > > Signed-off-by: Wisam Jaddo You should take this opportunity to document the logic for the allocation and peering of hairpin queues. It would be good to add short code comments for the variables as well. It confusing to have hairpinq and hairpin_q variables. Currently, we cannot really understand whether this fix is good or not. On hairpin topic, I suggest fixing this typo: hairping-rss -> hairpin-rss