From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53673A04B5; Wed, 30 Sep 2020 09:51:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 251B51D592; Wed, 30 Sep 2020 09:51:06 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id E6E3F1D446 for ; Wed, 30 Sep 2020 09:51:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id BA18511F0; Wed, 30 Sep 2020 03:50:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Sep 2020 03:50:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= JweX6XgWcconDjdl60thH2oA4Lfw1nZ/c2nQS64D3F8=; b=vcA/GnqBDRuLEMgZ a70s7PcOnwTjZjAUciRQYajZAGbFK/OZPpWjxXYiCvtCQHh7TQ1ZvldOyaYo6iZZ 6q0cWIeOd+Ms9tGh1wXVJaTlIK2fygD6fQcN5oeyq3n2rNm5C/Ju7GAcbco7NPTH mFFBbO0qv7Tlh/WpnjkW0ToJYmVRnp9NO3Y8VS1r/A70XmMekWcpZgZ4b87HVb4E 3jK4ZTPxMLu18/wrne0NLAHc6UvEsipBawSv6UZgJaJkFRLAyUm/UR0KTKQ8rObB RNsMvDRWnNE0aqfE6+/MPokOkUcrDk+NWIatolaDroqXIIuBrsZOQtLU8Wl+McVB GV5zhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=JweX6XgWcconDjdl60thH2oA4Lfw1nZ/c2nQS64D3 F8=; b=lDLRIf2NpPg2j2Rz+z24Dx7v2rd3pLvdqohASU2AEbGMjvDT9CWFnFj9h miSMuawRU1WMni48XvaYwazAEmG/LkJVXfBOt7EO9bMcUqFy3dv7v7XzURfYD8j6 MLqguyC647NRsUtvvECK48pnMPfgWVMoaOvMAWqlTvCPCdWLspVukTl8Ci8UNXNX v+/HHh44Mwl2HB2EIFOZOmpxhhH4z4XISXg7hrv/3Jt04j/9f2wyNfEq4Koym2As KSxcRGYsv0pk2z4mhhi2k5Axj9i8x1Qjchoin8YRoxsZK8QhaFcekLq8P0PmwiOf cCTgfXhl6Kxm4s2GuqI3ZuLNF+CpA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfedtgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 497C1328005E; Wed, 30 Sep 2020 03:50:56 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org, Kalesh A P Cc: ferruh.yigit@intel.com, ajit.khaparde@broadcom.com, arybchenko@solarflare.com Date: Wed, 30 Sep 2020 09:50:54 +0200 Message-ID: <3129125.UTyNnJLbx8@thomas> In-Reply-To: <20200930071258.22457-2-kalesh-anakkur.purayil@broadcom.com> References: <20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com> <20200930071258.22457-1-kalesh-anakkur.purayil@broadcom.com> <20200930071258.22457-2-kalesh-anakkur.purayil@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH v3 1/3] ethdev: support device reset and recovery events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Please use --cc-cmd devtools/get-maintainer.sh so all relevant maintainers are Cc'ed. Adding Andrew. > From: Kalesh AP > > Adding support for device reset and recovery events in the > rte_eth_event framework. FW error and FW reset conditions would be > managed internally by PMD without needing application intervention. > In such cases, PMD would need reset/recovery events to notify application > that PMD is undergoing a reset. We already have this event: RTE_ETH_EVENT_INTR_RESET, /**< reset interrupt event, sent to VF on PF reset */ I don't know why "INTR" is in the name of this event, and I think it does not need to be restricted to VF. The application does not need to know whether the reset is caused by the PF, the FW or the HW. That's why I think you could share the same event. > + RTE_ETH_EVENT_RESET, /**< port resetting from an error */ > + RTE_ETH_EVENT_RECOVERED, /**< port recovered from an error */ You ignored my previous comments: " What the application is supposed to do when receiving such event? How the application knows that flow rules were resetted? Is there any other configuration resetted? These informations must be explicit in the doxygen comments. "