From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 72A52B3DE for ; Thu, 12 Feb 2015 16:44:47 +0100 (CET) Received: by mail-wg0-f53.google.com with SMTP id x13so10889696wgg.12 for ; Thu, 12 Feb 2015 07:44:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=MdYKPSgYZoMnFSlCBwTPQTn+8awxUkN3VIKSLkIUzrM=; b=l6UDA0yUqD5z+eWrhpQrPI//2zNOd6lNVQXDCEYcPFjuPUGzCtLF+Kd8dnH/ptwwBt tjrCCAnpkJaCKXpDgniI9K3dAG6AGK2Qt4Ik4KXtrkW5PMXOZbvTWUl1PZc7M7M0Nz63 4mhFl87RkUnS0U4YRDCDwGf5FvXVxTUjjRoXdHZ/tryzR3jY+SQeeEgXtdi5OcLVJs5E KYh/N8nWCXMWZg96ObpUd3l7+RkNFkV/rHxOmvk4BaXKvNG8x7fgLsKLNKYzIGIsMB3t 62inj/Uv6vtvMwkQfzAO0+GAukpqkPKzL2QevrjSqxxGDM8KPbRsQZpn5ORTWc4+EVfe Sh7A== X-Gm-Message-State: ALoCoQnn20hUx3mPjT7r1udPPyqsbvhPWHymPLncE3zY8aj2ld5fCGuU+G8v9XIUMJcxR5vDUim/ X-Received: by 10.194.79.226 with SMTP id m2mr9118029wjx.60.1423755887291; Thu, 12 Feb 2015 07:44:47 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fs8sm3032319wib.8.2015.02.12.07.44.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Feb 2015 07:44:46 -0800 (PST) From: Thomas Monjalon To: "Gonzalez Monroy, Sergio" , Panu Matilainen Date: Thu, 12 Feb 2015 16:44:18 +0100 Message-ID: <3129786.dHlkKq5arh@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F4AC14@IRSMSX108.ger.corp.intel.com> References: <6ca22ee1257e34ee2b89f2fb354d6c382b8f3e29.1423644785.git.pmatilai@redhat.com> <54DB3C35.9000104@redhat.com> <91383E96CE459D47BCE92EFBF5CE73B004F4AC14@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 15:44:47 -0000 2015-02-11 12:31, Gonzalez Monroy, Sergio: > From: Panu Matilainen [mailto:pmatilai@redhat.com] > > On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote: > > > I think that vhost is being linked in the wrong place (plugins section). > > > The plugins only get linked when building static libraries. > > > I think the patch should also remove vhost from the plugins section. > > > > Right, so vhost isn't a pluggable driver in the sense that pmds are. I wont > > claim to be familiar with all this virt-related puzzle pieces :) I'll send an > > updated patch, I was just looking to fix build in my particular config and > > ignored the rest. > > > > On a related note, shouldn't librte_pmd_bond and librte_pmd_xenvirt be > > included in the plugins section along with all the other pmds? > > > Hi Panu, > > Good question :) > > I did wonder the same thing not long ago. > > I think the reason is that (someone may correct me if I'm wrong) there > are specific unit tests for those pmds (testing extra API) that require > them to always be linked against. A library is considered as a plugin if there is no public API and it registers itself. That's the case of normal PMD. But bonding and Xen have some library parts with public API. It has been discussed and agreed for bonding but I'm not aware of the Xen case.