From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 03A38282;
 Thu,  2 Feb 2017 11:18:06 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga105.fm.intel.com with ESMTP; 02 Feb 2017 02:18:05 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="1090022932"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga001.jf.intel.com with ESMTP; 02 Feb 2017 02:18:04 -0800
To: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
References: <1485348178-43771-1-git-send-email-shahafs@mellanox.com>
 <1485863129-6326-1-git-send-email-shahafs@mellanox.com>
 <20170131154201.GC16389@autoinstall.dev.6wind.com>
 <d5512631-529c-fd2d-14fb-d829c971e2d1@intel.com>
 <20170202082027.GL16389@autoinstall.dev.6wind.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>, adrien.mazarguil@6wind.com,
 dev@dpdk.org, stable@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <312e3c35-7a45-8cfa-6b47-8a545f6b47fd@intel.com>
Date: Thu, 2 Feb 2017 10:18:03 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170202082027.GL16389@autoinstall.dev.6wind.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix link status
	query
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Feb 2017 10:18:07 -0000

On 2/2/2017 8:20 AM, Nélio Laranjeiro wrote:
> On Wed, Feb 01, 2017 at 06:31:17PM +0000, Ferruh Yigit wrote:
>> On 1/31/2017 3:42 PM, Nélio Laranjeiro wrote:
>>> On Tue, Jan 31, 2017 at 01:45:29PM +0200, Shahaf Shuler wrote:
>>>> Trying to query the link status through new kernel ioctl API
>>>> ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
>>>> The bug was fixed on version 4.9
>>>> this patch uses the legacy ioctl API for lower kernels.
>>>>
>>>> Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
>>>> CC: stable@dpdk.org
>>>>
>>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>>
>>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>> Applied to dpdk-next-net/master, thanks.
>>
>> (Updated kernel version check to:
>> "+#if KERNEL_VERSION(4, 9, 0) < LINUX_VERSION_CODE")
> 
> Ferruh,
> 
> The issue is fixed in 4.9, so <= 4.9 is correct.
> 
> Am I missing something?

My bad Nelio,

I converted back to original, please check.

> 
> Regards,
>