From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6AF5A00B8; Sun, 27 Oct 2019 21:39:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6A6E1BF09; Sun, 27 Oct 2019 21:39:45 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id C09C21BEFF; Sun, 27 Oct 2019 21:39:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4D6885DD; Sun, 27 Oct 2019 16:39:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 16:39:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MJp37W+jSfGONgdW2baOun5WghyITtf6CZIEMTWuizM=; b=GNw76dU7tjJk U6C7RpEEY7LxvadgHatn3ZZVTnXu9CgNC/Zr27izguEVtTjRwu5GkP9lydxWisY7 F832MnUihm3jIzXhGXQJSO7VzHPVnMNSDRkvBjlcvBA+Lx2wUcDGzoQluGloBLJU BNRnNN8CVgXQCdyCNjsGUuckTA66Oq0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MJp37W+jSfGONgdW2baOun5WghyITtf6CZIEMTWui zM=; b=OHVmvjS12Xraj1sGQv/S9gIjl/bF0ujB5aZ/s3rEdEpW6FyollqY47O1u kbw9/Xim8FE3EpBDJsQaoQJxBQXh2EuPv4XgcEd/omLGqeUqBjS6OB1BsXxND1Ov ROg4edxRtMQScEzzpg9+PgqgOqrjpNviOS6ny2bd0/G5R0buRI1nFRfYx5WlD3OL IgPKHPUylHtWyxUBFdUWF66fgFY2xEJ8ES+NLxT5LzG0zXdnkkN+Xf+el1QnyBw2 YILHHiYVxij/cxRrqjf8HljWs55ch+QLGUMz3J254haRroCbF3eaRYmYxTqtru4U qrq0WmxQhQYSeiKEP6xR8LqBuCPeQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E02FD60057; Sun, 27 Oct 2019 16:39:40 -0400 (EDT) From: Thomas Monjalon To: Robin Jarry Cc: dev@dpdk.org, Stephen Hemminger , Kevin Laatz , Andrius Sirvys , Ciara Power , Reshma Pattan , stable@dpdk.org Date: Sun, 27 Oct 2019 21:39:38 +0100 Message-ID: <3132706.1A4gHmE3Kd@xps> In-Reply-To: <20191017103715.4ac27fce@hermes.lan> References: <20191017173212.1038-1-robin.jarry@6wind.com> <20191017103715.4ac27fce@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] usertools: fix py3 syntax errors with dpdk-telemetry-client.py X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/10/2019 19:37, Stephen Hemminger: > On Thu, 17 Oct 2019 19:32:12 +0200 > Robin Jarry wrote: > > > When running the dpdk-telemetry-client.py with python 3, we get the > > following syntax errors: > > > > File "usertools/dpdk-telemetry-client.py", line 70 > > print "\nResponse: \n", str(data) > > ^ > > SyntaxError: invalid syntax > > > > File "usertools/dpdk-telemetry-client.py", line 93 > > print "\nResponse: \n", str(data) > > ^ > > SyntaxError: invalid syntax > > > > File "usertools/dpdk-telemetry-client.py", line 111 > > file_path = sys.argv[1] > > ^ > > TabError: inconsistent use of tabs and spaces in indentation > > > > Import print_function from __future__ and add parentheses where missing. > > Also, use spaces for indentation everywhere. > > > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > Cc: Andrius Sirvys > > Cc: Ciara Power > > Cc: Kevin Laatz > > Cc: Reshma Pattan > > Cc: stable@dpdk.org > > Signed-off-by: Robin Jarry > > Acked-by: Stephen Hemminger Applied, thanks