From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 34F22288C for ; Thu, 26 Jul 2018 20:11:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CCD7321D1F; Thu, 26 Jul 2018 14:11:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 14:11:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=x1kcFo+WNeNk2uQFEjNZadX4qQ AV8hC5MWVjDKClDBc=; b=mRNmdHlb3w93W6X4kCNMVRIDIQEKAIq6/v/FQSr9F0 ZiG9wJdql6g2VNhpCYVJIAACNhjn+bZ5S197kWL5tZ6a0Xyw9I8YblHjIrtSpXkh huOH4fJn8ImFvxhSdF0l3M4buFjHPe38bCV83+rzqEWfxfUy7unEUcHTAc2OzklB Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=x1kcFo +WNeNk2uQFEjNZadX4qQAV8hC5MWVjDKClDBc=; b=BUCS00Ioed2w/bA0QgKwS6 +p4DaUnXTLFMPlBVt/2uW9KmiTBkDCC/FXXFjA8v1kaP9aDsBG9iJjmxod4dvDMi ogQKLlW4VoboeltKg7AP0P5U2bWNbEkyB8pmIbijPlbNnDtkB4AyhxndYfWlhh6B jxc0VYdxiMHpC8Pu64ojqCzMDWSgWYw4ZwZiw5JNyUrhmaAF1IrT5wMUjZaDWjsk UqfnJQQjU9eTFqVW9py+ghHECbPZZkkYVuOA8zX31KxZ00p5U61/kPm6+yowHB98 TlhlrFWqxBzVe96d/kfn+IxKXTUWDtAYRX2Xb/HmTBz0mq6Q0Tk7KAcjUF6QNJnQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DB1B81026C; Thu, 26 Jul 2018 14:11:04 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 26 Jul 2018 20:11:00 +0200 Message-ID: <3135038.1Nyv25uGYd@xps> In-Reply-To: <402f4c38-6ed2-e279-b6dc-e382b0efa250@intel.com> References: <20180706132119.9013-1-remy.horton@intel.com> <402f4c38-6ed2-e279-b6dc-e382b0efa250@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 18:11:06 -0000 Remy, You are not new to DPDK. Please pay attention to details: - subject does not start with lib/ - fixes of old commits must have Cc: stable@dpdk.org 20/07/2018 17:31, Ferruh Yigit: > On 7/6/2018 2:21 PM, Remy Horton wrote: > > This patchset adds a check to rte_metrics_update_values() > > that prevents the updating of metrics when presented with > > an invalid metric key. Previously, doing the latter could > > result in a crash. > > > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > > > Signed-off-by: Remy Horton > > Acked-by: Ferruh Yigit Applied, thanks