From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
chaozhu@linux.vnet.ibm.com, gowrishankar.m@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH v6] eal: provide API for querying valid socket id's
Date: Mon, 02 Apr 2018 17:27:40 +0200 [thread overview]
Message-ID: <3135662.d5SUXWziWm@xps> (raw)
In-Reply-To: <cb7e7ee4-c501-a554-7265-734331debe80@intel.com>
31/03/2018 15:35, Burakov, Anatoly:
> On 27-Mar-18 5:24 PM, Thomas Monjalon wrote:
> > 22/03/2018 13:36, Anatoly Burakov:
> >> --- a/lib/librte_eal/common/include/rte_eal.h
> >> +++ b/lib/librte_eal/common/include/rte_eal.h
> >> @@ -57,6 +57,9 @@ enum rte_proc_type_t {
> >> struct rte_config {
> >> uint32_t master_lcore; /**< Id of the master lcore */
> >> uint32_t lcore_count; /**< Number of available logical cores. */
> >> + uint32_t numa_node_count; /**< Number of detected NUMA nodes. */
> >> + uint32_t numa_nodes[RTE_MAX_NUMA_NODES];
> >> + /**< List of detected numa nodes. */
> >
> > Please keep this comment on the same line if it's below 99 chars.
>
> If this is allowed, can we fix checkpatch to not report error in these
> cases?
Checkpatch is just a tool, not an authority.
In this case, given all other lines are formatted with comments
at the end of lines, it is better to do the same if the line size
is reasonnable.
next prev parent reply other threads:[~2018-04-02 15:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 11:58 [dpdk-dev] [PATCH] eal: add function to return number of detected sockets Anatoly Burakov
2017-12-22 12:41 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-01-11 22:20 ` Thomas Monjalon
2018-01-12 11:44 ` Burakov, Anatoly
2018-01-12 11:50 ` Thomas Monjalon
2018-01-16 11:56 ` Burakov, Anatoly
2018-01-16 12:20 ` Thomas Monjalon
2018-01-16 15:05 ` Burakov, Anatoly
2018-01-16 17:34 ` Thomas Monjalon
2018-01-16 17:38 ` Burakov, Anatoly
2018-01-16 18:26 ` Thomas Monjalon
2018-01-16 17:53 ` [dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal Anatoly Burakov
2018-01-23 10:39 ` Mcnamara, John
2018-02-07 10:10 ` Jerin Jacob
2018-02-09 14:42 ` Bruce Richardson
2018-02-14 0:04 ` Thomas Monjalon
2018-02-14 14:25 ` Thomas Monjalon
2018-02-12 16:00 ` Jonas Pfefferle
[not found] ` <cover.1517848624.git.anatoly.burakov@intel.com>
2018-02-05 16:37 ` [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets Anatoly Burakov
2018-02-05 17:39 ` Burakov, Anatoly
2018-02-05 22:45 ` Thomas Monjalon
2018-02-06 9:28 ` Burakov, Anatoly
2018-02-06 9:47 ` Thomas Monjalon
2018-02-07 9:58 ` [dpdk-dev] [PATCH 18.05 v4] Add " Anatoly Burakov
2018-02-07 9:58 ` [dpdk-dev] [PATCH 18.05 v4] eal: add " Anatoly Burakov
2018-03-08 12:12 ` Bruce Richardson
2018-03-08 14:38 ` Burakov, Anatoly
2018-03-09 16:32 ` Bruce Richardson
2018-03-20 22:43 ` Thomas Monjalon
2018-03-21 4:59 ` gowrishankar muthukrishnan
2018-03-21 10:24 ` Burakov, Anatoly
2018-03-22 5:16 ` gowrishankar muthukrishnan
2018-03-22 9:04 ` Burakov, Anatoly
2018-03-22 10:58 ` [dpdk-dev] [PATCH v5] eal: provide API for querying valid socket id's Anatoly Burakov
2018-03-22 11:45 ` Burakov, Anatoly
2018-03-22 12:36 ` [dpdk-dev] [PATCH v6] " Anatoly Burakov
2018-03-22 17:07 ` gowrishankar muthukrishnan
2018-03-27 16:24 ` Thomas Monjalon
2018-03-31 13:35 ` Burakov, Anatoly
2018-04-02 15:27 ` Thomas Monjalon [this message]
2018-03-31 17:08 ` [dpdk-dev] [PATCH v7] " Anatoly Burakov
2018-04-04 22:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3135662.d5SUXWziWm@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).