DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: stable@dpdk.org,
	Alejandro Lucero <alejandro.lucero@netronome.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: limit use of address hint
Date: Wed, 03 Apr 2019 19:22:21 +0200	[thread overview]
Message-ID: <3135879.TiRoyuhVem@xps> (raw)
In-Reply-To: <CAD+H993HE6UzJrbQRV7woy9Bv4cN4tdOSNm0XLBg6QOo1nwfnA@mail.gmail.com>

02/04/2019 19:23, Alejandro Lucero:
> On Tue, Apr 2, 2019 at 5:13 PM Burakov, Anatoly <anatoly.burakov@intel.com>
> wrote:
> > On 31-Mar-19 9:43 AM, Shahaf Shuler wrote:
> > > patch[1] added an address hint as starting address for 64 bit systems in
> > > case an explicit base virtual address was not set by the user.
> > >
> > > The justification for such hint was to help devices that work in VA
> > > mode and has a address range limitation to work smoothly with the eal
> > > memory subsystem.
> > >
> > > While the base address value selected may work fine for the eal
> > > initialization, it easily breaks when trying to register external memory
> > > using rte_extmem_register API.
> > >
> > > Trying to register anonymous memory on RH x86_64 machine took several
> > > minutes, during them the function eal_get_virtual_area repeatedly
> > > scanned for a good VA candidate.
> > >
> > > The attempt to guess which VA address will be free for mapping will
> > > always result in not portable, error prone code:
> > > * different application may use different libraries along w/ DPDK. One
> > >    can never guess which library was called first and how much virtual
> > >    memory it consumed.
> > > * external memory can be registered at any time in the application run
> > >    time.
> > >
> > > In order not to break the existing secondary process design, this patch
> > > only limits the max number of tries that will be done with the
> > > address hint.
> > > When the number of tries exceeds the threshold the code
> > > will use the suggested address from kernel.
> > >
> > > Fixes: 1df21702873d ("mem: use address hint for mapping hugepages")
> > > Cc: stable@dpdk.org
> > > Cc: alejandro.lucero@netronome.com
> > >
> > > [1] commit 1df21702873d ("mem: use address hint for mapping hugepages")
> > >
> > > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > > ---
> > >
> > > On v2:
> > >   * instead of a complete remove of the hint limit the number of tries
> > we allow.
> > > ---
> >
> > LGTM
> >
> > Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >
> > We can always increase the number of tries later :)
> >
> This is also fine for me.
> If the map address is not within the supported range by a device with
> addressing limitations, the device will not be used.
> Not sure how this is likely to happen, but I guess if it is become a
> problem, another solution should be implemented.
> 
> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Applied, thanks

  parent reply	other threads:[~2019-04-03 17:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 20:21 [dpdk-dev] [PATCH] mem: don't use address hint for mapping unless requested Shahaf Shuler
2019-03-21 20:21 ` Shahaf Shuler
2019-03-27  5:36 ` Shahaf Shuler
2019-03-27  5:36   ` Shahaf Shuler
2019-03-27 11:49 ` Burakov, Anatoly
2019-03-27 11:49   ` Burakov, Anatoly
2019-03-28  8:45   ` Shahaf Shuler
2019-03-28  8:45     ` Shahaf Shuler
2019-03-28 10:26     ` Burakov, Anatoly
2019-03-28 10:26       ` Burakov, Anatoly
2019-03-31  8:43 ` [dpdk-dev] [PATCH v2] mem: limit use of address hint Shahaf Shuler
2019-03-31  8:43   ` Shahaf Shuler
2019-04-02 16:13   ` Burakov, Anatoly
2019-04-02 16:13     ` Burakov, Anatoly
2019-04-02 17:23     ` Alejandro Lucero
2019-04-02 17:23       ` Alejandro Lucero
2019-04-03 17:22       ` Thomas Monjalon [this message]
2019-04-03 17:22         ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3135879.TiRoyuhVem@xps \
    --to=thomas@monjalon.net \
    --cc=alejandro.lucero@netronome.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).